Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky task end state check #287

Closed
wants to merge 1 commit into from
Closed

Fix flaky task end state check #287

wants to merge 1 commit into from

Conversation

oerling
Copy link
Contributor

@oerling oerling commented Sep 23, 2021

A Task changes to kFinished state after producing all output and
finishing the testing cursor. Therefore the test may rarely see the
unfinished state even though the finished state will be set. Report
incorrect end state after a wait.

Fix flaky task end state check
6cf7568 
A Task changes to kFinished state after producing all output and
finishing the testing cursor. Therefore the test may rarely see the
unfinished state even though the finished state will be set. Report
incorrect end state after a wait.
@oerling oerling requested a review from mbasmanova September 23, 2021 19:28
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2021
@facebook-github-bot
Copy link
Contributor

@oerling has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@oerling merged this pull request in 79c395d.

zhouyuan pushed a commit to zhouyuan/velox that referenced this pull request May 31, 2023
@PHILO-HE
Support kPreceeding & kFollowing for window range frame type (faceboo…
d3da837 
…kincubator#287)

* Initial commit

* Fix compile issue

* Cherry pick PR 4510

* Fix issue in upstream PR

* Fix bugs for unique sort key

* Fix bugs for repeated sort key

* Add more test cases

* Fix int type issue

* Handle null

* Remove some commented code

* Remove check null

* Fix velox ut failure for rows frame

* Format the code
zhouyuan pushed a commit to zhouyuan/velox that referenced this pull request Jun 6, 2023
@PHILO-HE @zhejiangxiaomai
Support kPreceeding & kFollowing for window range frame type (faceboo…
ce48a27 
…kincubator#287)

* Initial commit

* Fix compile issue

* Cherry pick PR 4510

* Fix issue in upstream PR

* Fix bugs for unique sort key

* Fix bugs for repeated sort key

* Add more test cases

* Fix int type issue

* Handle null

* Remove some commented code

* Remove check null

* Fix velox ut failure for rows frame

* Format the code
zhouyuan pushed a commit to zhouyuan/velox that referenced this pull request Jun 7, 2023
@zhejiangxiaomai
Folder: exec
65aee45 
relative pr:

Fix hashjoin runtime issue facebookincubator#106
INVALID_STATE on HashJoin when spill is turned on facebookincubator#154
SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
zhouyuan pushed a commit to zhouyuan/velox that referenced this pull request Jun 7, 2023
@zhejiangxiaomai
Folder: function
731b4be 
relative pr:

Fix replace SparkSQL function facebookincubator#277
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
support timestamp hash facebookincubator#269
Spark sum can overflow facebookincubator#101
Support float & double types in pmod function facebookincubator#157
Implement datetime functions in velox/sparksql. facebookincubator#81
Fix type check in MapFunction facebookincubator#273
Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124
Register lpad/rpad functions for Spark SQL. facebookincubator#63
Support substring_index sql function facebookincubator#189
Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245
Support date_add spark sql function facebookincubator#144
PHILO-HE added a commit to PHILO-HE/velox that referenced this pull request Jun 27, 2023
@PHILO-HE @zhejiangxiaomai
Support kPreceeding & kFollowing for window range frame type (faceboo…
7921c88 
…kincubator#287)

* Initial commit

* Fix compile issue

* Cherry pick PR 4510

* Fix issue in upstream PR

* Fix bugs for unique sort key

* Fix bugs for repeated sort key

* Add more test cases

* Fix int type issue

* Handle null

* Remove some commented code

* Remove check null

* Fix velox ut failure for rows frame

* Format the code
Yohahaha pushed a commit to Yohahaha/velox that referenced this pull request Jul 4, 2023
@zhejiangxiaomai
Folder: exec
de7528f 
relative pr:

Fix hashjoin runtime issue facebookincubator#106
INVALID_STATE on HashJoin when spill is turned on facebookincubator#154
SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
Yohahaha pushed a commit to Yohahaha/velox that referenced this pull request Jul 4, 2023
@zhejiangxiaomai
Folder: function
44b2919 
relative pr:

Fix replace SparkSQL function facebookincubator#277
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
support timestamp hash facebookincubator#269
Spark sum can overflow facebookincubator#101
Support float & double types in pmod function facebookincubator#157
Implement datetime functions in velox/sparksql. facebookincubator#81
Fix type check in MapFunction facebookincubator#273
Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124
Register lpad/rpad functions for Spark SQL. facebookincubator#63
Support substring_index sql function facebookincubator#189
Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245
Support date_add spark sql function facebookincubator#144
chenxu14 pushed a commit to chenxu14/velox that referenced this pull request Jul 5, 2023
@zhejiangxiaomai
Folder: exec
a72a76b 
relative pr:

Fix hashjoin runtime issue facebookincubator#106
INVALID_STATE on HashJoin when spill is turned on facebookincubator#154
SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
chenxu14 pushed a commit to chenxu14/velox that referenced this pull request Jul 5, 2023
@zhejiangxiaomai
Folder: function
eaf2b52 
relative pr:

Fix replace SparkSQL function facebookincubator#277
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
support timestamp hash facebookincubator#269
Spark sum can overflow facebookincubator#101
Support float & double types in pmod function facebookincubator#157
Implement datetime functions in velox/sparksql. facebookincubator#81
Fix type check in MapFunction facebookincubator#273
Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124
Register lpad/rpad functions for Spark SQL. facebookincubator#63
Support substring_index sql function facebookincubator#189
Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245
Support date_add spark sql function facebookincubator#144
PHILO-HE pushed a commit to PHILO-HE/velox that referenced this pull request Jul 17, 2023
@zhejiangxiaomai
Folder: exec
1c61c3a 
relative pr:

Fix hashjoin runtime issue facebookincubator#106
INVALID_STATE on HashJoin when spill is turned on facebookincubator#154
SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
PHILO-HE pushed a commit to PHILO-HE/velox that referenced this pull request Jul 17, 2023
@zhejiangxiaomai
Folder: function
e7fa7f5 
relative pr:

Fix replace SparkSQL function facebookincubator#277
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
support timestamp hash facebookincubator#269
Spark sum can overflow facebookincubator#101
Support float & double types in pmod function facebookincubator#157
Implement datetime functions in velox/sparksql. facebookincubator#81
Fix type check in MapFunction facebookincubator#273
Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124
Register lpad/rpad functions for Spark SQL. facebookincubator#63
Support substring_index sql function facebookincubator#189
Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245
Support date_add spark sql function facebookincubator#144
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Jul 21, 2023
@zhejiangxiaomai @rui-mo
Folder: exec
c5128a9 
relative pr:

Fix hashjoin runtime issue facebookincubator#106
INVALID_STATE on HashJoin when spill is turned on facebookincubator#154
SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Jul 21, 2023
@zhejiangxiaomai @rui-mo
Folder: function
4fd11ad 
relative pr:

Fix replace SparkSQL function facebookincubator#277
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
support timestamp hash facebookincubator#269
Spark sum can overflow facebookincubator#101
Support float & double types in pmod function facebookincubator#157
Implement datetime functions in velox/sparksql. facebookincubator#81
Fix type check in MapFunction facebookincubator#273
Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124
Register lpad/rpad functions for Spark SQL. facebookincubator#63
Support substring_index sql function facebookincubator#189
Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245
Support date_add spark sql function facebookincubator#144
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Jul 24, 2023
@zhejiangxiaomai @rui-mo
Folder: exec
848c895 
relative pr:

Fix hashjoin runtime issue facebookincubator#106
INVALID_STATE on HashJoin when spill is turned on facebookincubator#154
SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Jul 24, 2023
@zhejiangxiaomai @rui-mo
Folder: function
f98feb6 
relative pr:

Fix replace SparkSQL function facebookincubator#277
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
support timestamp hash facebookincubator#269
Spark sum can overflow facebookincubator#101
Support float & double types in pmod function facebookincubator#157
Implement datetime functions in velox/sparksql. facebookincubator#81
Fix type check in MapFunction facebookincubator#273
Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124
Register lpad/rpad functions for Spark SQL. facebookincubator#63
Support substring_index sql function facebookincubator#189
Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245
Support date_add spark sql function facebookincubator#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasmanova mbasmanova mbasmanova approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oerling @facebook-github-bot @mbasmanova