-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(OWNERS): remove inactive approvers #2116
Conversation
Signed-off-by: Jason Dellaluce <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jason Dellaluce <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been on hold for 13 days now. It has been blocked because of the pending "change requests" (and the reviewer decided to step down). In any case, the change looks legit to me since I have not seen any relevant activity from them in the last 6 months (as per our governance), and in the last year in general.
I think all the remaining maintainers agree (cc @mstemm @jasondellaluce @FedeDP ). So, I'd ask @jasondellaluce to close this PR and open a new one.
I agree and confirm my standpoint as in falcosecurity/evolution#157. Considering that the reviewers expressed their will to step down, I'm closing this in favor of #2134. /close |
@jasondellaluce: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from
approvers
toemeritus_approvers
in OWNERS.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: