Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(OWNERS): move inactive approvers to emeritus_approvers #2134

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from approvers to emeritus_approvers in OWNERS.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Opened this in place of #2116, as following up the suggestion of #2116 (review).

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, as per my comment here.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 19, 2022

LGTM label has been added.

Git tree hash: 879c7767862f1bfb53641f30b24a0d70fde1b0b3

@leogr
Copy link
Member

leogr commented Jul 19, 2022

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jul 19, 2022
@leogr leogr requested a review from FedeDP July 19, 2022 12:18
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 0cab9ba into master Jul 20, 2022
@poiana poiana deleted the cleanup/move-inactive-approvers branch July 20, 2022 08:40
@poiana
Copy link
Contributor

poiana commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants