Smaller fixes for packaging #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- correct repo url - tensorflow as an extra requirement - add bigfish as a `find_package`
Rename _init_.py to __init__.py
Fix setup.py by removing `include=bigfish`
|
"squash and merge" would probably better, I was trying a few things resulting in a bunch of commits. |
Henley13
pushed a commit
that referenced
this pull request
May 5, 2020
* Update setup.py - correct repo url - tensorflow as an extra requirement - add bigfish as a `find_package` Co-authored-by: Wei Ouyang <[email protected]>
Henley13
pushed a commit
that referenced
this pull request
May 14, 2020
* Update setup.py - correct repo url - tensorflow as an extra requirement - add bigfish as a `find_package` Co-authored-by: Wei Ouyang <[email protected]>
Henley13
pushed a commit
that referenced
this pull request
May 14, 2020
* Update setup.py - correct repo url - tensorflow as an extra requirement - add bigfish as a `find_package` Co-authored-by: Wei Ouyang <[email protected]>
Henley13
added a commit
that referenced
this pull request
May 15, 2020
Henley13
added a commit
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
__init__.pyin bigfish directory. otherwise pip install won't work (thanks @oeway) . more details here: https://stackoverflow.com/questions/12966216/make-distutils-in-python-automatically-find-packages/14376861#14376861tensorflow as a separate requirement in setup.py
smaller fixes of typos and urls in setup.py