-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.64] Terminal profiles stopped working #288
Comments
I have the same issue. I've also tested running vscode natively from their provided tarball, and there doesn't seem to be any issue there. |
Same here, im trying to set zsh as default, but it is stuck on sh. |
Found that using the depricated option "terminal.integrated.shell.linux": "/usr/bin/flatpak-spawn",
"terminal.integrated.shellArgs.linux": [
"--host",
"--env=TERM='xterm-256color'",
"/bin/bash"
], Log(Window) keeps throwing error |
For now, I'm just using an older version until this gets fixed
|
Thx, seems like not only flatpak issue - microsoft/vscode#143307 . |
From the interaction on microsoft/vscode#146981 the problem seems to be related to not accessing Is it possible that the flatpak installation restricts the visibility of And I confirm that on my system there is a |
You can work around the issue by running this from the ( |
This unfortunately doesn't work for me - it creates an empty /etc/shells on Fedora 36 and VSCode Flatpak 1.66.1 but when I re-open VSCode the terminal still cannot access system-wide environment (npm, etc). This is the only fix that works on Fedora 36 (workstation) for now - the downgrade.
Edit: reported on microsoft/vscode#146981 |
Ack - microsoft/vscode#146981 got closed because
So what changed between 1.63 and 1.64 that broke shells for the flatpak? |
Resolves: #288 The shell discovery process in vscode crashes if `/etc/shells` does not exist, resulting in no shells being available (including any custom profiles). This will link `/var/run/host/etc/shells` to `/etc/shells` if the latter is missing.
After update to version 1.64.1 and 1.64.2 there is just the /bin/sh shell.
Vscode stopped to detect terminal profiles like described in https://github.com/flathub/com.visualstudio.code/blob/a89bb4af634b4a216a1dd1c8db7debffdf2a0b30/flatpak-warning.txt.
The profiles do not show up at all.
Downgrading to version 1.63 makes the profiles work again.
I tested the same version of the upstream rpm package and the profiles seem to work here.
OS: Fedora Linux 35.20220213.0 (Silverblue)
Version of vscode: 1.64.2
Version of Flatpak: 1.12.4
Logs
The text was updated successfully, but these errors were encountered: