Create /etc/shells if it is missing
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #288 The shell discovery process in vscode crashes if `/etc/shells` does not exist, resulting in no shells being available (including any custom profiles). This will link `/var/run/host/etc/shells` to `/etc/shells` if the latter is missing.
|
Started test build 89432 |
|
Untested, will test this in a few hours. |
|
Build 89432 successful |
|
Tested on Silverblue 36. |
|
Works well for me on Fedora 36 Workstation, as long as I have my settings.json set up as directed at first startup. Thank you for the fix! This enables me to stop using the deprecated workaround for settings.json listed in the bug #288 thread. |
|
@nedrichards does this make sense to merge? Thank you! |
|
So far works well for me (Fedora 35 Silverblue). 👍 |
|
Yep - working flawlessly. Been working with it full-time for the past 3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #288
The shell discovery process in vscode crashes if
/etc/shellsdoes not exist, resulting in no shells being available (including any custom profiles). This will link/var/run/host/etc/shellsto/etc/shellsif the latter is missing.