Backing to depricated option to Integrated Terminal

[felipemarkson]

The solution for Integrated Terminal doesn't work anymore.

More details of the problem in: #288

[flathubbot]

Started test build 86198

[flathubbot]

Build 86198 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/84043/com.visualstudio.code.flatpakref

[nikodunk]

@nedrichards FYI with #309 the non-depricated option for the integrated terminal works great for me too. Are we sure we want to suggest the depricated option by default again?

[Nightfirecat]

I can confirm as of cfc88be I was using the recommended terminal setup prior to this change without issue, since #309 was merged--it was working fine. This PR suggests using a deprecated method for setting the terminal which should be avoided. I strongly recommend reverting this merge.

[nikodunk]

Agreed. @barthalion @nedrichards can we revert this merge? There's already so much confusion out there as to whether the terminal works on VSCode Flatpak or not - recommending a deprecated solution is not going to help our cause.

[nedrichards]

I'll take a closer look. It's not ideal for sure.

[nikodunk]

Would it be helpful to open a PR to update to the current syntax for settings.json as we had before?