Added version in flyteadmin #154

yindia · 2021-03-03T22:20:01Z

TL;DR

Added GetVersion GRPC Call

Type

Bug Fix
Feature
Plugin

Are all requirements met?

Complete description

Tracking Issue

flyteorg/flyte#173

Follow-up issue

codecov · 2021-03-12T19:14:10Z

Codecov Report

Merging #154 (9303571) into master (ce66045) will increase coverage by 0.27%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   62.79%   63.07%   +0.27%     
==========================================
  Files         100      101       +1     
  Lines        7284     7301      +17     
==========================================
+ Hits         4574     4605      +31     
+ Misses       2124     2116       -8     
+ Partials      586      580       -6

Flag	Coverage Δ
unittests	`63.07% <75.00%> (+0.27%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/config/serverconfig_flags.go	`68.00% <20.00%> (-5.34%)`	⬇️
pkg/manager/impl/version_manager.go	`100.00% <100.00%> (ø)`
pkg/runtime/namespace_config_provider.go	`7.14% <0.00%> (-1.20%)`	⬇️
pkg/common/namespace.go	`100.00% <0.00%> (ø)`
pkg/repositories/gormimpl/common.go	`57.14% <0.00%> (ø)`
pkg/repositories/gormimpl/metrics.go	`100.00% <0.00%> (ø)`
pkg/repositories/transformers/execution.go	`76.92% <0.00%> (+0.11%)`	⬆️
pkg/manager/impl/execution_manager.go	`68.98% <0.00%> (+0.67%)`	⬆️
pkg/manager/impl/node_execution_manager.go	`68.57% <0.00%> (+1.66%)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce66045...9303571. Read the comment docs.

pkg/manager/mocks/version.go

version/version.go

Signed-off-by: yuvraj <[email protected]>

yindia · 2021-03-24T07:48:43Z

@kumare3 @katrogan pr is ready you can review. I tested version service call in flytectl

pkg/manager/impl/version_manager_test.go

pkg/rpc/adminservice/version.go

Signed-off-by: yuvraj <[email protected]>

.goreleaser.yml

Signed-off-by: yuvraj <[email protected]>

* wip: added version pkg Signed-off-by: yuvraj <[email protected]> * wip: resolve conflict Signed-off-by: yuvraj <[email protected]> * wip: added version in rpc Signed-off-by: yuvraj <[email protected]> * wip: small fixes Signed-off-by: yuvraj <[email protected]> * wip: Added panic cache in get version service Signed-off-by: yuvraj <[email protected]> * Added flytestdlib for version package Signed-off-by: yuvraj <[email protected]> * Added version service test Signed-off-by: yuvraj <[email protected]> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <[email protected]>

* wip: added version pkg Signed-off-by: yuvraj <[email protected]> * wip: resolve conflict Signed-off-by: yuvraj <[email protected]> * wip: added version in rpc Signed-off-by: yuvraj <[email protected]> * wip: small fixes Signed-off-by: yuvraj <[email protected]> * wip: Added panic cache in get version service Signed-off-by: yuvraj <[email protected]> * Added flytestdlib for version package Signed-off-by: yuvraj <[email protected]> * Added version service test Signed-off-by: yuvraj <[email protected]> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>

…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <[email protected]> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <[email protected]> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <[email protected]> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <[email protected]> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <[email protected]> * update config Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fixed the pointer overwrite issue in oauthServer metadata (#183) Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix clusterresource Project and domain(#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Bump flyteidl version to pick up auth role field number fix (#169) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add option to use project name as namespace for the task pods (#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <[email protected]> * rename Signed-off-by: Jeev B <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * GetExecution performance improvements (#171) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add exists check for workflow & node executions (#172) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Remove legacy fetch for workflow execution inputs (#173) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added release workflow (#170) Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update Flyteidl version (#175) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added version in flyteadmin (#154) * wip: added version pkg Signed-off-by: yuvraj <[email protected]> * wip: resolve conflict Signed-off-by: yuvraj <[email protected]> * wip: added version in rpc Signed-off-by: yuvraj <[email protected]> * wip: small fixes Signed-off-by: yuvraj <[email protected]> * wip: Added panic cache in get version service Signed-off-by: yuvraj <[email protected]> * Added flytestdlib for version package Signed-off-by: yuvraj <[email protected]> * Added version service test Signed-off-by: yuvraj <[email protected]> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Propagate nesting and principal for child executions (#177) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Write workflow and node execution events asynchronously (#174) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add sensible flyteadmin config defaults (#179) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * further cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <[email protected]> * dead code Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]> * merge master Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update go mod Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Anand Swaminathan <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: Jeev B <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Flyte Bot <[email protected]>

* wip: added version pkg Signed-off-by: yuvraj <[email protected]> * wip: resolve conflict Signed-off-by: yuvraj <[email protected]> * wip: added version in rpc Signed-off-by: yuvraj <[email protected]> * wip: small fixes Signed-off-by: yuvraj <[email protected]> * wip: Added panic cache in get version service Signed-off-by: yuvraj <[email protected]> * Added flytestdlib for version package Signed-off-by: yuvraj <[email protected]> * Added version service test Signed-off-by: yuvraj <[email protected]> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <[email protected]>

…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <[email protected]> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <[email protected]> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <[email protected]> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <[email protected]> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <[email protected]> * update config Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fixed the pointer overwrite issue in oauthServer metadata (#183) Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix clusterresource Project and domain(#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Bump flyteidl version to pick up auth role field number fix (#169) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add option to use project name as namespace for the task pods (#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <[email protected]> * rename Signed-off-by: Jeev B <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * GetExecution performance improvements (#171) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add exists check for workflow & node executions (#172) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Remove legacy fetch for workflow execution inputs (#173) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added release workflow (#170) Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update Flyteidl version (#175) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added version in flyteadmin (#154) * wip: added version pkg Signed-off-by: yuvraj <[email protected]> * wip: resolve conflict Signed-off-by: yuvraj <[email protected]> * wip: added version in rpc Signed-off-by: yuvraj <[email protected]> * wip: small fixes Signed-off-by: yuvraj <[email protected]> * wip: Added panic cache in get version service Signed-off-by: yuvraj <[email protected]> * Added flytestdlib for version package Signed-off-by: yuvraj <[email protected]> * Added version service test Signed-off-by: yuvraj <[email protected]> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Propagate nesting and principal for child executions (#177) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Write workflow and node execution events asynchronously (#174) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add sensible flyteadmin config defaults (#179) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * further cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <[email protected]> * dead code Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]> * merge master Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update go mod Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Anand Swaminathan <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: Jeev B <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Flyte Bot <[email protected]>

yindia changed the title ~~Added version in flyteadmin~~ [WIP] Added version in flyteadmin Mar 4, 2021

yindia changed the title ~~[WIP] Added version in flyteadmin~~ Added version in flyteadmin Mar 12, 2021

yindia marked this pull request as ready for review March 12, 2021 21:52

yindia requested review from anandswaminathan, EngHabu, katrogan, kumare3 and wild-endeavor as code owners March 12, 2021 21:52

katrogan reviewed Mar 12, 2021

View reviewed changes

pkg/manager/mocks/version.go Outdated Show resolved Hide resolved

katrogan reviewed Mar 12, 2021

View reviewed changes

version/version.go Outdated Show resolved Hide resolved

yindia requested a review from katrogan March 15, 2021 17:09

katrogan previously approved these changes Mar 15, 2021

View reviewed changes

yindia dismissed katrogan’s stale review via 665c648 March 15, 2021 18:46

yindia added 3 commits March 24, 2021 01:14

wip: added version pkg

9340cf7

Signed-off-by: yuvraj <[email protected]>

wip: resolve conflict

4d6901d

Signed-off-by: yuvraj <[email protected]>

wip: added version in rpc

d0e7c92

Signed-off-by: yuvraj <[email protected]>

yindia requested a review from katrogan March 24, 2021 05:00

wip: small fixes

fa70a14

Signed-off-by: yuvraj <[email protected]>

katrogan reviewed Mar 24, 2021

View reviewed changes

pkg/manager/impl/version_manager_test.go Outdated Show resolved Hide resolved

katrogan reviewed Mar 24, 2021

View reviewed changes

pkg/rpc/adminservice/version.go Outdated Show resolved Hide resolved

wip: Added panic cache in get version service

1a9e841

Signed-off-by: yuvraj <[email protected]>

yindia requested a review from katrogan March 25, 2021 05:49

katrogan previously approved these changes Mar 25, 2021

View reviewed changes

Added flytestdlib for version package

d3601d2

Signed-off-by: yuvraj <[email protected]>

yindia dismissed katrogan’s stale review via d3601d2 April 1, 2021 19:55

yindia requested a review from katrogan April 1, 2021 20:06

Added version service test

e70b4b5

Signed-off-by: yuvraj <[email protected]>

EngHabu reviewed Apr 8, 2021

View reviewed changes

.goreleaser.yml Outdated Show resolved Hide resolved

wip: added ldflags in goreleaser

9303571

Signed-off-by: yuvraj <[email protected]>

yindia requested a review from EngHabu April 8, 2021 14:19

katrogan approved these changes Apr 8, 2021

View reviewed changes

EngHabu merged commit 19af628 into flyteorg:master Apr 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added version in flyteadmin #154

Added version in flyteadmin #154

yindia commented Mar 3, 2021 •

edited

Loading

codecov bot commented Mar 12, 2021 •

edited

Loading

yindia commented Mar 24, 2021

Added version in flyteadmin #154

Added version in flyteadmin #154

Conversation

yindia commented Mar 3, 2021 • edited Loading

TL;DR

Type

Are all requirements met?

Complete description

Tracking Issue

Follow-up issue

codecov bot commented Mar 12, 2021 • edited Loading

Codecov Report

yindia commented Mar 24, 2021

yindia commented Mar 3, 2021 •

edited

Loading

codecov bot commented Mar 12, 2021 •

edited

Loading