Add exists check for workflow & node executions

[katrogan]

Signed-off-by: Katrina Rogan [email protected]

TL;DR

Add exists check for workflow & node executions to avoid fetching and passing around fully fledged executions in memory.

Additionally, only add the exists check for these parent executions when node and task executions, respectively, are not found and we create an entry in the db for them for the first time.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

Tracking Issue

flyteorg/flyte#880

Follow-up issue

NA

[codecov]

Codecov Report

Merging #172 (158a063) into master (2db25e0) will increase coverage by 0.22%.
The diff coverage is 92.53%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   62.82%   63.04%   +0.22%     
==========================================
  Files         100      100              
  Lines        7257     7295      +38     
==========================================
+ Hits         4559     4599      +40     
+ Misses       2116     2114       -2     
  Partials      582      582              

Flag	Coverage Δ
unittests	63.04% <92.53%> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/manager/impl/launch_plan_manager.go	61.79% <ø> (ø)
pkg/repositories/gormimpl/common.go	57.14% <ø> (ø)
pkg/repositories/gormimpl/launch_plan_repo.go	63.63% <ø> (ø)
pkg/repositories/gormimpl/task_repo.go	68.11% <ø> (ø)
pkg/repositories/gormimpl/workflow_repo.go	69.11% <ø> (ø)
pkg/manager/impl/util/shared.go	62.99% <75.00%> (ø)
pkg/repositories/gormimpl/execution_repo.go	67.41% <84.61%> (+2.94%)	⬆️
pkg/repositories/gormimpl/node_execution_repo.go	64.60% <87.50%> (+3.77%)	⬆️
pkg/manager/impl/execution_manager.go	68.87% <100.00%> (ø)
pkg/manager/impl/node_execution_manager.go	68.57% <100.00%> (+1.66%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db25e0...158a063. Read the comment docs.

[kumare3]

This is great!

[kumare3]

I tested this change, seems good to go, performance improvement is not great, but this is the right change nevertheless