This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fixed the pointer overwrite issue in oauthServer metadata #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
requested review from
anandswaminathan,
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
8 tasks
kumare3
reviewed
Apr 14, 2021
| @@ -76,8 +76,9 @@ func getJSONWebKeys(publicKeys []rsa.PublicKey) (jwk.Set, error) { | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to write public key. Error: %w", err) | |||
| } | |||
|
|
|||
| err = key.Set(KeyMetadataPublicCert, &publicKey) | |||
| var localPublicKey rsa.PublicKey | |||
There was a problem hiding this comment.
Suggested change
| var localPublicKey rsa.PublicKey | |
| localPublicKey := publicKey |
just replace with oneline
EngHabu
pushed a commit
that referenced
this pull request
Apr 26, 2021
Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
pushed a commit
that referenced
this pull request
Apr 26, 2021
Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
added a commit
that referenced
this pull request
Apr 30, 2021
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <[email protected]> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <[email protected]> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <[email protected]> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <[email protected]> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <[email protected]> * update config Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fixed the pointer overwrite issue in oauthServer metadata (#183) Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix clusterresource Project and domain(#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Bump flyteidl version to pick up auth role field number fix (#169) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add option to use project name as namespace for the task pods (#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <[email protected]> * rename Signed-off-by: Jeev B <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * GetExecution performance improvements (#171) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add exists check for workflow & node executions (#172) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Remove legacy fetch for workflow execution inputs (#173) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added release workflow (#170) Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update Flyteidl version (#175) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added version in flyteadmin (#154) * wip: added version pkg Signed-off-by: yuvraj <[email protected]> * wip: resolve conflict Signed-off-by: yuvraj <[email protected]> * wip: added version in rpc Signed-off-by: yuvraj <[email protected]> * wip: small fixes Signed-off-by: yuvraj <[email protected]> * wip: Added panic cache in get version service Signed-off-by: yuvraj <[email protected]> * Added flytestdlib for version package Signed-off-by: yuvraj <[email protected]> * Added version service test Signed-off-by: yuvraj <[email protected]> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Propagate nesting and principal for child executions (#177) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Write workflow and node execution events asynchronously (#174) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add sensible flyteadmin config defaults (#179) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * further cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <[email protected]> * dead code Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]> * merge master Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update go mod Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Anand Swaminathan <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: Jeev B <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Flyte Bot <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <[email protected]> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <[email protected]> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <[email protected]> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <[email protected]> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <[email protected]> * update config Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fixed the pointer overwrite issue in oauthServer metadata (#183) Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix clusterresource Project and domain(#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Bump flyteidl version to pick up auth role field number fix (#169) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add option to use project name as namespace for the task pods (#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <[email protected]> * rename Signed-off-by: Jeev B <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * GetExecution performance improvements (#171) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add exists check for workflow & node executions (#172) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Remove legacy fetch for workflow execution inputs (#173) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added release workflow (#170) Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update Flyteidl version (#175) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added version in flyteadmin (#154) * wip: added version pkg Signed-off-by: yuvraj <[email protected]> * wip: resolve conflict Signed-off-by: yuvraj <[email protected]> * wip: added version in rpc Signed-off-by: yuvraj <[email protected]> * wip: small fixes Signed-off-by: yuvraj <[email protected]> * wip: Added panic cache in get version service Signed-off-by: yuvraj <[email protected]> * Added flytestdlib for version package Signed-off-by: yuvraj <[email protected]> * Added version service test Signed-off-by: yuvraj <[email protected]> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Propagate nesting and principal for child executions (#177) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Write workflow and node execution events asynchronously (#174) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add sensible flyteadmin config defaults (#179) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * further cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <[email protected]> * dead code Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]> * merge master Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update go mod Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Anand Swaminathan <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: Jeev B <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Flyte Bot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prafulla Mahindrakar [email protected]
Read then delete
will be bumped. More details
TL;DR
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/