-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShaderData
add get shader properties ability
#1030
Merged
GuoLei1990
merged 14 commits into
galacean:dev/0.9
from
GuoLei1990:pr/shaderData-improve
Sep 14, 2022
Merged
ShaderData
add get shader properties ability
#1030
GuoLei1990
merged 14 commits into
galacean:dev/0.9
from
GuoLei1990:pr/shaderData-improve
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
requested review from
gz65555,
zhuxudong,
yangfengzzz,
cptbtptpbcptdtptp,
singlecoder and
a team
September 10, 2022 07:43
Codecov Report
@@ Coverage Diff @@
## dev/0.9 #1030 +/- ##
===========================================
+ Coverage 29.52% 33.38% +3.85%
===========================================
Files 331 332 +1
Lines 14704 14730 +26
Branches 2251 2261 +10
===========================================
+ Hits 4341 4917 +576
+ Misses 9849 9268 -581
- Partials 514 545 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
50 tasks
GuoLei1990
changed the title
feat: shaderData add getProperties ability
feat: shaderData add get assigned shader properties ability
Sep 10, 2022
GuoLei1990
added
enhancement
New feature or request
shader
Shader related functions
labels
Sep 10, 2022
GuoLei1990
changed the title
feat: shaderData add get assigned shader properties ability
feat: shaderData add get shader properties ability
Sep 10, 2022
Add Unit Test for new API Done |
gz65555
reviewed
Sep 13, 2022
…rData-improve * commit 'f34d3ace905a74861fb2852afa0a2ce99fe3032d': Fix text renderer element not render state (galacean#1043) Shader support multi shader pass (galacean#948) v0.9.0-alpha.4 fix: use rgba8 as downgrade shadow texture (galacean#1033) v0.9.0-alpha.3 shadowMap using color texture when platform not support depthTexture (galacean#1029) Fix `SkinnedMeshRenderer` clone bug (galacean#1028)
gz65555
approved these changes
Sep 14, 2022
GuoLei1990
changed the title
feat: shaderData add get shader properties ability
shaderData add get shader properties ability
Sep 14, 2022
GuoLei1990
changed the title
shaderData add get shader properties ability
Sep 14, 2022
ShaderData
add get shader properties ability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
ShaderData
addgetProperties(out: ShaderProperty[]): void
andgetProperties(): ShaderProperty[]
method, developer can get all shaderProperties that have been set on this shaderData.example:
Material.test.ts