Optimization Transform direction related API
#1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
changed the title
GuoLei1990
changed the title
Transform direction related API
GuoLei1990
requested review from
gz65555,
yangfengzzz,
zhuxudong and
cptbtptpbcptdtptp
yangfengzzz
approved these changes
Feb 22, 2023
Codecov ReportBase: 40.71% // Head: 41.93% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## dev/1.0 #1381 +/- ##
===========================================
+ Coverage 40.71% 41.93% +1.22%
===========================================
Files 351 351
Lines 17788 17785 -3
Branches 2605 2608 +3
===========================================
+ Hits 7242 7458 +216
+ Misses 9896 9633 -263
- Partials 650 694 +44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Mar 2, 2023
…xt-restore * commit 'add6e916a8327e492f8fec16bc0e7cd543a59566': Move font map cache from `Font` to `Engine` (galacean#1387) "v1.0.0-alpha.0" glTF parse support custom extsnions and parser (galacean#1008) Optimization `Transform` direction related API (galacean#1381) refactor: opt code refactor: opt code refactor: opt code refactor: opt code refactor: opt code feat: refactor transform API Add `toJSON` in base math class (galacean#1380)
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Mar 16, 2023
* dev/1.0: (41 commits) fix: package.json Support device lost (galacean#1374) "v0.9.0-beta.70" fix: add shadow parser (galacean#1411) Add `toJSON` in base math class (galacean#1380) (galacean#1409) refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410) "v0.9.0-beta.69" Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405) Support shader replacement and sub shader (galacean#1394) Fix camera cull bug (galacean#1396) "v0.9.0-beta.68" fix: InputManager default listener target "v0.9.0-beta.67" Fix shader compile performance on some windows device (galacean#1390) Move font map cache from `Font` to `Engine` (galacean#1387) "v1.0.0-alpha.0" glTF parse support custom extsnions and parser (galacean#1008) Optimization `Transform` direction related API (galacean#1381) refactor: opt code refactor: opt code ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Improve the usability of transform API:
getWorldForward(forward: Vector3)->get worldForwardgetWorldRight(right: Vector3)->get worldRightgetWorldUp(up: Vector3)->get worldUp