Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix particle system bug(temp no clipped) #1410

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

singlecoder
Copy link
Member

…em and it will never be clipped

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@singlecoder singlecoder added this to the 0.9 milestone Mar 15, 2023
@singlecoder singlecoder self-assigned this Mar 15, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (9b68d68) 40.85% compared to head (8aa8dd8) 40.82%.

❗ Current head 8aa8dd8 differs from pull request most recent head baf3f46. Consider uploading reports for the commit baf3f46 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   40.85%   40.82%   -0.03%     
==========================================
  Files         350      350              
  Lines       17772    17777       +5     
  Branches     2587     2587              
==========================================
- Hits         7260     7258       -2     
- Misses       9876     9882       +6     
- Partials      636      637       +1     
Impacted Files Coverage Δ
packages/core/src/particle/ParticleRenderer.ts 3.54% <0.00%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Mar 15, 2023
@GuoLei1990 GuoLei1990 changed the title Add an infinite bounding box to the particle system and it will never be clipped Temp fix particle system clipped bug Mar 15, 2023
@GuoLei1990 GuoLei1990 changed the title Temp fix particle system clipped bug Fix particle system bug(temp no clipped) Mar 15, 2023
@GuoLei1990 GuoLei1990 merged commit 92fb306 into galacean:main Mar 15, 2023
GuoLei1990 added a commit that referenced this pull request Mar 15, 2023
* main:
  "v0.9.0-beta.70"
  fix: add shadow parser (#1411)
  Add `toJSON` in base math class (#1380) (#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (#1405)
  Fix camera cull bug (#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (#1390)
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 16, 2023
* dev/1.0: (41 commits)
  fix: package.json
  Support device lost  (galacean#1374)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Support shader replacement and sub shader (galacean#1394)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  Move font map cache from `Font` to `Engine` (galacean#1387)
  "v1.0.0-alpha.0"
  glTF parse support custom extsnions and parser (galacean#1008)
  Optimization `Transform` direction related API (galacean#1381)
  refactor: opt code
  refactor: opt code
  ...
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 30, 2023
* main: (514 commits)
  "v0.9.0-beta.73"
  fix: scene parser error (galacean#1426)
  Fix SpriteRenderer bounding box error (galacean#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (galacean#1414)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  "v0.9.0-beta.66"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants