Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toJSON in base math class #1380

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Add toJSON in base math class #1380

merged 4 commits into from
Feb 21, 2023

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Feb 21, 2023

Fix #1194

@gz65555 gz65555 requested a review from GuoLei1990 February 21, 2023 03:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023 •
edited
Loading

Codecov Report

Base: 41.83% // Head: 40.71% // Decreases project coverage by -1.13% ⚠️

Coverage data is based on head (d8a2ffe) compared to base (f004089).
Patch coverage: 90.00% of modified lines in pull request are covered.

❗ Current head d8a2ffe differs from pull request most recent head 090d4ab. Consider uploading reports for the commit 090d4ab to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/1.0    #1380      +/-   ##
===========================================
- Coverage    41.83%   40.71%   -1.13%     
===========================================
  Files          351      351              
  Lines        17778    17788      +10     
  Branches      2605     2605              
===========================================
- Hits          7438     7242     -196     
- Misses        9650     9896     +246     
+ Partials       690      650      -40
Impacted Files Coverage Δ
packages/math/src/Quaternion.ts 84.34% <50.00%> (-0.23%) ⬇️
packages/math/src/Color.ts 62.83% <100.00%> (-1.14%) ⬇️
packages/math/src/Vector2.ts 77.58% <100.00%> (-1.37%) ⬇️
packages/math/src/Vector3.ts 82.29% <100.00%> (+0.18%) ⬆️
packages/math/src/Vector4.ts 85.34% <100.00%> (+0.15%) ⬆️
packages/core/src/RenderPipeline/RenderContext.ts 28.57% <0.00%> (-71.43%) ⬇️
...ges/core/src/RenderPipeline/BasicRenderPipeline.ts 18.25% <0.00%> (-32.54%) ⬇️
packages/core/src/Camera.ts 30.45% <0.00%> (-20.31%) ⬇️
packages/rhi-webgl/src/WebGLRenderer.ts 38.56% <0.00%> (-18.96%) ⬇️
...ckages/core/src/shadow/CascadedShadowCasterPass.ts 13.25% <0.00%> (-16.58%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 changed the title feat: add toJSON in base math class Add toJSON in base math class Feb 21, 2023
GuoLei1990
GuoLei1990 reviewed Feb 21, 2023
View reviewed changes
packages/math/src/Color.ts Outdated

/**
* json serialization.
* return {r: number, g: number, b: number, a: number}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @returns

@GuoLei1990 GuoLei1990 merged commit 08aaa77 into galacean:dev/1.0 Feb 21, 2023
@GuoLei1990 GuoLei1990 linked an issue Feb 21, 2023 that may be closed by this pull request
Math add toJSON() ability #1194
Closed
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 2, 2023
@GuoLei1990
Merge commit 'add6e916a8327e492f8fec16bc0e7cd543a59566' into pr/conte…
4dbb60e 
…xt-restore

* commit 'add6e916a8327e492f8fec16bc0e7cd543a59566':
  Move font map cache from `Font` to `Engine` (galacean#1387)
  "v1.0.0-alpha.0"
  glTF parse support custom extsnions and parser (galacean#1008)
  Optimization `Transform` direction related API (galacean#1381)
  refactor: opt code
  refactor: opt code
  refactor: opt code
  refactor: opt code
  refactor: opt code
  feat: refactor transform API
  Add `toJSON` in base math class (galacean#1380)
@gz65555 gz65555 deleted the feat/add-tojson branch March 15, 2023 06:58
gz65555 added a commit to gz65555/engine-1 that referenced this pull request Mar 15, 2023
@gz65555
Add toJSON in base math class (galacean#1380)
08d2b5d 
* feat: add toJSON in base math class
GuoLei1990 pushed a commit that referenced this pull request Mar 15, 2023
@gz65555
Add toJSON in base math class (#1380) (#1409)
4e94f65 
* feat: add toJSON in base math class
GuoLei1990 added a commit that referenced this pull request Mar 15, 2023
@GuoLei1990
Merge branch 'main' into dev/1.0
65c129f 
* main:
  "v0.9.0-beta.70"
  fix: add shadow parser (#1411)
  Add `toJSON` in base math class (#1380) (#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (#1405)
  Fix camera cull bug (#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (#1390)
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 16, 2023
@GuoLei1990
Merge branch 'dev/1.0' into pr/refactor-time
c203931 
* dev/1.0: (41 commits)
  fix: package.json
  Support device lost  (galacean#1374)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Support shader replacement and sub shader (galacean#1394)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  Move font map cache from `Font` to `Engine` (galacean#1387)
  "v1.0.0-alpha.0"
  glTF parse support custom extsnions and parser (galacean#1008)
  Optimization `Transform` direction related API (galacean#1381)
  refactor: opt code
  refactor: opt code
  ...
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 30, 2023
@GuoLei1990
Merge branch 'main' into cr/fix-vao
0726a72 
* main: (514 commits)
  "v0.9.0-beta.73"
  fix: scene parser error (galacean#1426)
  Fix SpriteRenderer bounding box error (galacean#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (galacean#1414)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  "v0.9.0-beta.66"
  ...
@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Math add toJSON() ability
3 participants
@gz65555 @codecov-commenter @GuoLei1990