Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix the default listener target for InputManager pointer" #1414

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Mar 16, 2023

Reverts #1393

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (2eb3ad6) 40.85% compared to head (4be0016) 40.84%.

❗ Current head 4be0016 differs from pull request most recent head b17eff6. Consider uploading reports for the commit b17eff6 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
- Coverage   40.85%   40.84%   -0.02%     
==========================================
  Files         350      350              
  Lines       17793    17793              
  Branches     2592     2592              
==========================================
- Hits         7269     7267       -2     
- Misses       9888     9889       +1     
- Partials      636      637       +1     
Impacted Files Coverage Δ
...ackages/core/src/input/keyboard/KeyboardManager.ts 47.82% <ø> (ø)
packages/core/src/input/pointer/PointerManager.ts 26.57% <66.66%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Mar 16, 2023
@GuoLei1990 GuoLei1990 merged commit 5d4071e into main Mar 16, 2023
@GuoLei1990 GuoLei1990 deleted the revert-1393-fix/target branch March 18, 2023 13:02
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 30, 2023
* main: (514 commits)
  "v0.9.0-beta.73"
  fix: scene parser error (galacean#1426)
  Fix SpriteRenderer bounding box error (galacean#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (galacean#1414)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  "v0.9.0-beta.66"
  ...
GuoLei1990 added a commit that referenced this pull request Mar 30, 2023
* main:
  Fix `Mesh` change IndexBuffer、VertexBuffer、VertexElements bug( need to update VAO) (#719)
  "v0.9.0-beta.73"
  fix: scene parser error (#1426)
  Fix SpriteRenderer bounding box error (#1425)
  Update README.md
  Update README.md
  "v0.9.0-beta.72"
  "v0.9.0-beta.71"
  Revert "fix: InputManager default listener target" (#1414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants