Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 ➡️ 7 #156

Merged
merged 27 commits into from
Sep 8, 2020
Merged

6 ➡️ 7 #156

merged 27 commits into from
Sep 8, 2020

Conversation

chapulina
Copy link
Contributor

No description provided.

claireyywang and others added 24 commits April 18, 2020 08:18
Signed-off-by: claireyywang <[email protected]>
* [ign-math6] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>

* Update include/ignition/math/Material.hh

Co-Authored-By: Alejandro Hernández Cordero <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
* Make alpha optional when parsing a Color from an input stream

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Steven Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
* Add AxisAlignedBox::Volume imp

Signed-off-by: Ian Chen <[email protected]>

* changelog

Signed-off-by: Ian Chen <[email protected]>
…an build on ubuntu 16.04 (#119)

Signed-off-by: Andrew Somerville <[email protected]>
This implements the functions Min(), Min(Vector4), Max() and Max(Vector4) in Vector4 API, similar to the existing same functions in Vector3.

Signed-off-by: Lucas Fernando <[email protected]>
* Add Abs, Dot and AbsDot and respective tests to Vector4

Signed-off-by: Lucas Fernando <[email protected]>

* Requested test addition for completion

Signed-off-by: Lucas Fernando <[email protected]>
- Abs() => Get the absolute value of the vector
- AbsDot() => The absolute dot product
- Correct() => Corrects any nan values

Create unit test for all functions.

These functions intend to solve issue #71
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Felipe Ximenes <[email protected]>
* Upload of Vector4 ruby tests and interface

Signed-off-by: Lucas Fernando <[email protected]>
Signed-off-by: Lucas Fernando <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Add install prerequisites and test subsection Ruby Tests

Signed-off-by: Lucas Fernando <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
…to Vector 4 (#146)

* Round, Rounded, Correct, Distance(x, y, z, w) and operator< addition to Vector4

Signed-off-by: Lucas Fernando <[email protected]>

* Correct test

Signed-off-by: Lucas Fernando <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
* Add function Max(Vector2) and test.

Signed-off-by: pxalcantara <[email protected]>

* Add Max() function and test.

Signed-off-by: pxalcantara <[email protected]>

* Add Min(Vector2) function and test.

Signed-off-by: pxalcantara <[email protected]>

* Add Min() function and test.

Signed-off-by: pxalcantara <[email protected]>

* Change doxygen and Max, Min comparison.

Signed-off-by: pxalcantara <[email protected]>

* add Max, Min function to Vector2.i

Signed-off-by: pxalcantara <[email protected]>

* add Max test to .rb file

Signed-off-by: pxalcantara <[email protected]>

* correct lint error

Signed-off-by: pxalcantara <[email protected]>

* Add test_Min to Vector2_TEST.rb

Signed-off-by: pxalcantara <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Added functions to convert between time_point and secNsec

Signed-off-by: ahcorde <[email protected]>

* Add function to convert a time_point in a string

Signed-off-by: ahcorde <[email protected]>

* Simplify math in timepoint convertions

Signed-off-by: ahcorde <[email protected]>

* make linters happy

Signed-off-by: ahcorde <[email protected]>

* make linters happy

Signed-off-by: ahcorde <[email protected]>

* make linters happy

Signed-off-by: ahcorde <[email protected]>

* Fixed test

Signed-off-by: ahcorde <[email protected]>

* Added test for timePointToString

Signed-off-by: ahcorde <[email protected]>

* Added documentation feedback

Signed-off-by: ahcorde <[email protected]>

* Fix macOS build

Cast to system_clock::duration where necessary.

Signed-off-by: Steve Peters <[email protected]>

* Fixed test and added a note with the precision on different OS

Signed-off-by: ahcorde <[email protected]>

* Change std::chrono::system_clock for std::chrono::steady_clock

Signed-off-by: ahcorde <[email protected]>

* Removed comment

Signed-off-by: ahcorde <[email protected]>

* Added feedback

Signed-off-by: ahcorde <[email protected]>

* alphabetize headers in helpers.hh

Signed-off-by: ahcorde <[email protected]>

Co-authored-by: John Shepherd <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@chapulina chapulina requested a review from scpeters as a code owner September 4, 2020 20:57
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #156 into master will decrease coverage by 0.25%.
The diff coverage is 97.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   98.80%   98.55%   -0.26%     
==========================================
  Files          59       59              
  Lines        5703     5890     +187     
==========================================
+ Hits         5635     5805     +170     
- Misses         68       85      +17     
Impacted Files Coverage Δ
include/ignition/math/AxisAlignedBox.hh 100.00% <ø> (ø)
include/ignition/math/MassMatrix3.hh 99.40% <ø> (-0.01%) ⬇️
include/ignition/math/Pose3.hh 87.40% <ø> (-0.20%) ⬇️
include/ignition/math/Vector4.hh 94.44% <95.16%> (-5.56%) ⬇️
include/ignition/math/Helpers.hh 98.75% <97.46%> (-1.25%) ⬇️
include/ignition/math/Color.hh 100.00% <100.00%> (ø)
include/ignition/math/Filter.hh 100.00% <100.00%> (ø)
include/ignition/math/Vector2.hh 100.00% <100.00%> (ø)
src/AxisAlignedBox.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3c4a3...d54a46b. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 029e350 into master Sep 8, 2020
@chapulina chapulina deleted the chapulina/6_to_7 branch September 8, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants