Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find GzURDFDOM, fix warning #1074

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Find GzURDFDOM, fix warning #1074

merged 2 commits into from
Jul 11, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 11, 2022

🦟 Bug fix

Fix deprecation warning from gazebosim/gz-cmake#273

Summary

Build Status https://build.osrfoundation.org/view/ign-garden/job/sdformat-ci-main-focal-amd64/100/cmake/

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fix deprecation warning.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner July 11, 2022 18:53
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 11, 2022
@scpeters scpeters mentioned this pull request Jul 11, 2022
9 tasks
@adityapande-1995
Copy link
Contributor

Are the pragma warnings related to the changes here ?

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1074 (1d75062) into main (a92a354) will increase coverage by 16.45%.
The diff coverage is 77.51%.

@@             Coverage Diff             @@
##             main    #1074       +/-   ##
===========================================
+ Coverage   66.66%   83.12%   +16.45%     
===========================================
  Files           2      154      +152     
  Lines          27    18702    +18675     
===========================================
+ Hits           18    15546    +15528     
- Misses          9     3156     +3147     
Impacted Files Coverage Δ
include/sdf/Exception.hh 100.00% <ø> (ø)
include/sdf/Filesystem.hh 100.00% <ø> (ø)
include/sdf/InterfaceElements.hh 75.00% <ø> (ø)
include/sdf/Param.hh 80.72% <ø> (ø)
include/sdf/Plugin.hh 93.75% <ø> (ø)
include/sdf/Types.hh 100.00% <ø> (ø)
python/src/sdf/pyAtmosphere.cc 60.00% <ø> (ø)
src/SDFExtension.hh 100.00% <ø> (ø)
src/Utils.hh 94.73% <ø> (ø)
python/src/sdf/pyRoot.cc 55.73% <33.33%> (ø)
... and 235 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17544db...1d75062. Read the comment docs.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

Are the pragma warnings related to the changes here ?

oops, there was a typo: see 1d75062

@scpeters scpeters merged commit 51e19d7 into main Jul 11, 2022
@scpeters scpeters deleted the scpeters/gz_urdfdom branch July 11, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants