Add capability for TOMAS simulations in GCHP #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melissa Sulprizio <[email protected]>
Signed-off-by: Melissa Sulprizio <[email protected]>
Resolved conflicts in: CHANGELOG.md src/GCHP_GridComp/GEOSChem_GridComp/CMakeLists.txt src/GCHP_GridComp/GEOSChem_GridComp/geos-chem src/GCHP_GridComp/HEMCO_GridComp/HEMCO Signed-off-by: Melissa Sulprizio <[email protected]>
Signed-off-by: Melissa Sulprizio <[email protected]>
Signed-off-by: Melissa Sulprizio <[email protected]>
This was referenced Dec 5, 2023
yantosca
requested changes
Dec 5, 2023
There was a problem hiding this comment.
This looks mostly good to merge, pending minor fixes as noted.
Also: The HEMCO submodule only has 2 files changed but the HEMCO PR #251 contains changes 3 files. We'll need to point to the updated commit in the HEMCO submodule.
Also bring dev/tomas branches in the GEOS-Chem and HEMCO submodules up-to-date. Signed-off-by: Melissa Sulprizio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
This pull request adds the option to run GCHP with TOMAS as originally implemented by @BettyCroft in:
This pull request should be merged alongside: