-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TOMAS extensions for use in GCHP #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piling The MSG variable was defined twice in HCOX_TOMAS_Jeagle_Run. The second occurrence has been removed, along with an unused ERR variable. Signed-off-by: Melissa Sulprizio <[email protected]>
There were an excessive amount of trailing whitespaces in hcox_tomas_jeagle_mod.F90 that affected readability of the file. These have now been removed. Signed-off-by: Melissa Sulprizio <[email protected]>
Resolved conflicts in: CHANGELOG.md src/Extensions/hcox_tomas_jeagle_mod.F90 Signed-off-by: Melissa Sulprizio <[email protected]>
Signed-off-by: Melissa Sulprizio <[email protected]>
TOMAS species SF6 has conflicts with sulfur hexafluoride (SF6) used in the TransportTracers simulation. To avoid conflicts, we rename all of the TOMAS species for bins 1-9 to use 01-09. This is done for all TOMAS species (NK*, SF*, SS*, ECOB*, ECIL*, OCOB*, OCIL*, AW*, and DUST*). Signed-off-by: Melissa Sulprizio <[email protected]>
This was referenced Dec 5, 2023
yantosca
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates bin numbers (e.g. NK1 -> NK01) and also implements the various updates made to the seasalt extension into the TOMAS seasalt extension. Good to merge.
msulprizio
added a commit
to geoschem/GCClassic
that referenced
this pull request
Dec 6, 2023
For more details see: - geoschem/geos-chem#2060 - geoschem/HEMCO#251 Signed-off-by: Melissa Sulprizio <[email protected]>
msulprizio
added a commit
to geoschem/GCHP
that referenced
this pull request
Dec 6, 2023
Add GEOS-Chem and HEMCO submodule updates for TOMAS simulations. For more details see also: - geoschem/geos-chem#2060 - geoschem/HEMCO#251 Signed-off-by: Melissa Sulprizio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
This pull request contains updates needed for implementing TOMAS in GCHP and should be merged alongside:
It supersedes #164.