Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TOMAS extensions for use in GCHP #251

Merged
merged 12 commits into from
Dec 6, 2023
Merged

Update TOMAS extensions for use in GCHP #251

merged 12 commits into from
Dec 6, 2023

Conversation

msulprizio
Copy link
Contributor

@msulprizio msulprizio commented Dec 5, 2023

Name and Institution (Required)

Name: Melissa Sulprizio
Institution: Harvard / GCST

Describe the update

This pull request contains updates needed for implementing TOMAS in GCHP and should be merged alongside:

It supersedes #164.

BettyCroft and others added 12 commits February 21, 2022 07:19
…piling

The MSG variable was defined twice in HCOX_TOMAS_Jeagle_Run. The second
occurrence has been removed, along with an unused ERR variable.

Signed-off-by: Melissa Sulprizio <[email protected]>
There were an excessive amount of trailing whitespaces in hcox_tomas_jeagle_mod.F90
that affected readability of the file. These have now been removed.

Signed-off-by: Melissa Sulprizio <[email protected]>
Resolved conflicts in:
	CHANGELOG.md
	src/Extensions/hcox_tomas_jeagle_mod.F90

Signed-off-by: Melissa Sulprizio <[email protected]>
TOMAS species SF6 has conflicts with sulfur hexafluoride (SF6) used in
the TransportTracers simulation. To avoid conflicts, we rename all of the
TOMAS species for bins 1-9 to use 01-09. This is done for all TOMAS species
(NK*, SF*, SS*, ECOB*, ECIL*, OCOB*, OCIL*, AW*, and DUST*).

Signed-off-by: Melissa Sulprizio <[email protected]>
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates bin numbers (e.g. NK1 -> NK01) and also implements the various updates made to the seasalt extension into the TOMAS seasalt extension. Good to merge.

@msulprizio msulprizio merged commit 33583d2 into dev/3.8.0 Dec 6, 2023
1 check passed
@msulprizio msulprizio deleted the dev/tomas branch December 6, 2023 17:24
msulprizio added a commit to geoschem/GCClassic that referenced this pull request Dec 6, 2023
msulprizio added a commit to geoschem/GCHP that referenced this pull request Dec 6, 2023
Add GEOS-Chem and HEMCO submodule updates for TOMAS simulations. For more
details see also:

- geoschem/geos-chem#2060
- geoschem/HEMCO#251

Signed-off-by: Melissa Sulprizio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: HEMCO Extensions Pertaining to HEMCO extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants