chore(eap-spans): Add a field to suggest consumers to ingest spans in EAP #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2024
jjbayer
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Could you implement this as an unserialized item header, as we did for replays?
relay/relay-server/src/envelope.rs
Lines 518 to 521 in 03325fb
jjbayer
approved these changes
Nov 4, 2024
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| source: relay-server/src/metrics_extraction/event.rs | |||
| expression: "(&event.value().unwrap().spans, metrics)" | |||
| expression: "(&event.value().unwrap().spans, metrics.project_metrics)" | |||
There was a problem hiding this comment.
Interesting, where did this come from?
| @@ -330,6 +342,7 @@ pub fn extract_from_event( | |||
| item.set_payload(ContentType::Json, span); | |||
| // If metrics extraction happened for the event, it also happened for its spans: | |||
| item.set_metrics_extracted(state.event_metrics_extracted); | |||
| item.set_ingest_span_in_eap(ingest_in_eap); | |||
There was a problem hiding this comment.
We could make the header an envelope header and set it in a more central place (e.g. process_envelope), so we don't have to set it in two different code paths. Given this is temporary it does not really matter though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to have span ingestion into the EAP behind a feature flag. Snuba doesn't support runtime configuration for Rust consumers so the idea here is to have a Flagpole feature tell us whether or not we should ingest.
getsentry/sentry#80064
getsentry/snuba#6486