chore(eap-spans): Add feature to control span ingestion in EAP #80064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Zylphrex
approved these changes
Oct 31, 2024
jjbayer
reviewed
Oct 31, 2024
| @@ -65,6 +65,7 @@ | |||
| "projects:span-metrics-extraction", | |||
| "projects:span-metrics-extraction-addons", | |||
| "organizations:indexed-spans-extraction", | |||
| "organizations:ingest-spans-in-eap", | |||
There was a problem hiding this comment.
Does this flag need to be exposed to relay?
There was a problem hiding this comment.
Yes, I'm making a PR to Relay too so we can add a field to the span payload to let the Snuba EAP consumers know they should ingest the span or not.
jjbayer
approved these changes
Oct 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80064 +/- ##
==========================================
- Coverage 78.12% 78.11% -0.02%
==========================================
Files 7163 7159 -4
Lines 316700 316612 -88
Branches 43663 43646 -17
==========================================
- Hits 247414 247310 -104
- Misses 62944 62954 +10
- Partials 6342 6348 +6 |
phacops
deleted the
pierre/eap-spans-add-feature-to-control-span-ingestion
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan is to then tag each span with a field instructing the consumer to either ingest or discard.
getsentry/snuba#6486
getsentry/relay#4206