Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eap-spans): Respect the decision to ingest or not in EAP #6486

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Oct 31, 2024

@volokluev
Copy link
Member

would you need to update sentry_kafka_schemas?

@phacops
Copy link
Contributor Author

phacops commented Nov 1, 2024

would you need to update sentry_kafka_schemas?

We allow additional fields, and given this is a temporary one, mostly for the LA/GA, I'm tempted not to change the schema.

Copy link

codecov bot commented Nov 4, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2669 1 2668 5
View the top 1 failed tests by shortest run time
tests.web.rpc.v1.test_endpoint_time_series.TestTimeSeriesApi test_sum
Stack Traces | 0.616s run time
Traceback (most recent call last):
  File ".../rpc/v1/test_endpoint_time_series.py", line 210, in test_sum
    assert sorted(response.result_timeseries, key=lambda x: x.label) == [
AssertionError: assert [] == [label: "avg"\nbuckets {\n  seconds: 1730620800\n}\nbuckets {\n  seconds: 1730621100\n}\nbuckets {\n  seconds: 1730621400\n}\nbuckets {\n  seconds: 1730621700\n}\nbuckets {\n  seconds: 1730622000\n}\nbuckets {\n  seconds: 1730622300\n}\ndata_points {\n  data: 1\n  data_present: true\n}\ndata_points {\n  data: 1\n  data_present: true\n}\ndata_points {\n  data: 1\n  data_present: true\n}\ndata_points {\n  data: 1\n  data_present: true\n}\ndata_points {\n  data: 1\n  data_present: true\n}\ndata_points {\n  data: 1\n  data_present: true\n}\n,\n label: "sum"\nbuckets {\n  seconds: 1730620800\n}\nbuckets {\n  seconds: 1730621100\n}\nbuckets {\n  seconds: 1730621400\n}\nbuckets {\n  seconds: 1730621700\n}\nbuckets {\n  seconds: 1730622000\n}\nbuckets {\n  seconds: 1730622300\n}\ndata_points {\n  data: 300\n  data_present: true\n}\ndata_points {\n  data: 300\n  data_present: true\n}\ndata_points {\n  data: 300\n  data_present: true\n}\ndata_points {\n  data: 300\n  data_present: true\n}\ndata_points {\n  data: 300\n  data_present: true\n}\ndata_points {\n  data: 300\n  data_present: true\n}\n]
  Right contains 2 more items, first extra item: label: "avg"\nbuckets {\n  seconds: 1730620800\n}\nbuckets {\n  seconds: 1730621100\n}\nbuckets {\n  seconds: 1730621400\n}\nbuc...1\n  data_present: true\n}\ndata_points {\n  data: 1\n  data_present: true\n}\ndata_points {\n  data: 1\n  data_present: true\n}\n
  Full diff:
    [
  +  ,
  -  label: "avg"
  - buckets {
  -   seconds: 1730620800
  - }
  - buckets {
  -   seconds: 1730621100
  - }
  - buckets {
  -   seconds: 1730621400
  - }
  - buckets {
  -   seconds: 1730621700
  - }
  - buckets {
  -   seconds: 1730622000
  - }
  - buckets {
  -   seconds: 1730622300
  - }
  - data_points {
  -   data: 1
  -   data_present: true
  - }
  - data_points {
  -   data: 1
  -   data_present: true
  - }
  - data_points {
  -   data: 1
  -   data_present: true
  - }
  - data_points {
  -   data: 1
  -   data_present: true
  - }
  - data_points {
  -   data: 1
  -   data_present: true
  - }
  - data_points {
  -   data: 1
  -   data_present: true
  - }
  - ,
  -  label: "sum"
  - buckets {
  -   seconds: 1730620800
  - }
  - buckets {
  -   seconds: 1730621100
  - }
  - buckets {
  -   seconds: 1730621400
  - }
  - buckets {
  -   seconds: 1730621700
  - }
  - buckets {
  -   seconds: 1730622000
  - }
  - buckets {
  -   seconds: 1730622300
  - }
  - data_points {
  -   data: 300
  -   data_present: true
  - }
  - data_points {
  -   data: 300
  -   data_present: true
  - }
  - data_points {
  -   data: 300
  -   data_present: true
  - }
  - data_points {
  -   data: 300
  -   data_present: true
  - }
  - data_points {
  -   data: 300
  -   data_present: true
  - }
  - data_points {
  -   data: 300
  -   data_present: true
  - }
  - ,
    ]

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@phacops phacops merged commit 50abb85 into master Nov 4, 2024
30 checks passed
@phacops phacops deleted the pierre/eap-spans-add-allowlist branch November 4, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants