Fix gogit GetRefCommitID
#32705
Merged
Fix gogit GetRefCommitID
#32705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Dec 4, 2024
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Dec 4, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 4, 2024
GiteaBot
removed
the
reviewed/wait-merge
silverwind
pushed a commit
that referenced
this pull request
Dec 4, 2024
Backport #32705 by @Zettat123 Fix #32335 When we call `GetRefCommitID` and the reference is already a commit ID, the `GetRefCommitID` with go-git will return a `NotExist` error. This PR improves the `GetRefCommitID` for go-git. If the input is already a commit ID, it will be returned directly. Co-authored-by: Zettat123 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 5, 2024
* giteaofficial/main: Fix fork page branch selection (go-gitea#32711) Add Arch package registry (go-gitea#32692) Use new mail package instead of an unmintained one (go-gitea#32682) Fix mentionable users when writing issue comments (go-gitea#32715) Fix file editor & preview (go-gitea#32706) Remove outdated code about fixture generation (go-gitea#32708) Fix gogit `GetRefCommitID` (go-gitea#32705)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32335
When we call
GetRefCommitIDand the reference is already a commit ID, theGetRefCommitIDwith go-git will return aNotExisterror. This PR improves theGetRefCommitIDfor go-git. If the input is already a commit ID, it will be returned directly.