Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mentionable users when writing issue comments #32715

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix mentionable users when writing issue comments #32715

merged 1 commit into from
Dec 4, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #32702

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Dec 4, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 4, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 4, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 4, 2024
Closed
@wxiaoguang wxiaoguang force-pushed the fix-mention branch 2 times, most recently from ab60759 to 7db3b5b Compare December 4, 2024 13:21
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2024
@wxiaoguang wxiaoguang merged commit 4142397 into go-gitea:main Dec 4, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-mention branch December 4, 2024 14:57
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 5, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c172d7c 
* giteaofficial/main:
  Fix fork page branch selection (go-gitea#32711)
  Add Arch package registry (go-gitea#32692)
  Use new mail package instead of an unmintained one (go-gitea#32682)
  Fix mentionable users when writing issue comments (go-gitea#32715)
  Fix file editor & preview (go-gitea#32706)
  Remove outdated code about fixture generation (go-gitea#32708)
  Fix gogit `GetRefCommitID` (go-gitea#32705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

PR comment user tagging bug, users not found
4 participants
@wxiaoguang @wolfogre @delvh @GiteaBot