Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file editor & preview #32706

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix file editor & preview #32706

merged 2 commits into from
Dec 4, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 4, 2024 •
edited
Loading

Fix a regression caused by jQuery removal (renderPreviewPanelContent)

And simplify the file editor, it doesn't need to be that complex. And remove jQuery code.

The file editor is only used for 2 purposes:

  1. add/edit file
  2. apply patch

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 4, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Dec 4, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 4, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 4, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Dec 4, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 4, 2024 09:02
@wxiaoguang wxiaoguang merged commit 838653d into go-gitea:main Dec 4, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-editor-js branch December 4, 2024 10:03
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 5, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c172d7c 
* giteaofficial/main:
  Fix fork page branch selection (go-gitea#32711)
  Add Arch package registry (go-gitea#32692)
  Use new mail package instead of an unmintained one (go-gitea#32682)
  Fix mentionable users when writing issue comments (go-gitea#32715)
  Fix file editor & preview (go-gitea#32706)
  Remove outdated code about fixture generation (go-gitea#32708)
  Fix gogit `GetRefCommitID` (go-gitea#32705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @delvh @GiteaBot