Issue 2305 - add tab index to carousel thumbnails #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snovosel
requested review from
jrtashjian,
EvanHerman,
AnthonyLedesma,
jonathanbardo and
olafleur-godaddy
as code owners
snovosel
removed request for
jrtashjian,
jonathanbardo,
EvanHerman,
AnthonyLedesma and
olafleur-godaddy
snovosel
added
[Status] Needs Review
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Performance Test Results:
|
AnthonyLedesma
requested changes
Mar 23, 2022
There was a problem hiding this comment.
I came across a block validation error with this. Something with the deprecation doesn't seem right.
logger.js:17 Block validation: Expected attribute `class` of value `is-cropped coblocks-gallery has-no-alignment has-caption-style-dark has-horizontal-gutter has-no-thumbnails`, saw `coblocks-gallery-carousel-swiper-container is-cropped coblocks-gallery has-no-alignment has-caption-style-dark has-horizontal-gutter has-no-thumbnails`
There was a problem hiding this comment.
I was able to deprecate without issue. The Tabing works as expected now. The original issue reported mentioned a part about additional labeling. How do you feel about adding the additional labeling to the AC before we merge it in?
Screen reader users may need some extra labeling to explain what the buttons are for.
AnthonyLedesma
approved these changes
May 9, 2022
jrtashjian
added a commit
that referenced
this pull request
May 10, 2022
* Highlight block to core/paragraph * Bump composer/composer from 2.2.11 to 2.2.12 (#2363) Bumps [composer/composer](https://github.com/composer/composer) from 2.2.11 to 2.2.12. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.2.11...2.2.12) --- updated-dependencies: - dependency-name: composer/composer dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [skip ci] Update coblocks.pot/coblocks.json files * ->block_attributes() * Tweak * Changelog for 2.22.11 * 2.22.11 * [skip ci] Update coblocks.pot/coblocks.json files * Remove yarn.lock file * Update * Updates * Update * Updates to styles * Bump grunt from 1.4.1 to 1.5.2 (#2366) Bumps [grunt](https://github.com/gruntjs/grunt) from 1.4.1 to 1.5.2. - [Release notes](https://github.com/gruntjs/grunt/releases) - [Changelog](https://github.com/gruntjs/grunt/blob/main/CHANGELOG) - [Commits](gruntjs/grunt@v1.4.1...v1.5.2) --- updated-dependencies: - dependency-name: grunt dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [skip ci] Update coblocks.pot/coblocks.json files * Add a validation for the presence of the minor part in the version (#2365) * Add validation minor version part * Revert "Add validation minor version part" This reverts commit e578099. * Bump GoDaddy Styles to 0.4.0 * test random branch * publish branch * [skip ci] Update coblocks.pot/coblocks.json files * Fix some Cypress tests in WP 6.0 RC1 (#2372) * Fix Alert block cypress test * Fix author block test * Fix typography settings modal test * Fix highlight block test * Fix animation settings modal test * [skip ci] Update coblocks.pot/coblocks.json files * Fix more Cypress tests for WP 6.0 RC1 (#2373) * Fix logos block test * Fix dynamic separator block test * Fix Click to Tweet block test * Fix settings modal color extension test * [skip ci] Update coblocks.pot/coblocks.json files * Add e2e tests with PHP 8.0 (#2375) * Add e2e tests with PHP 8.1 * TT2 * Only 8.0 is supported for the moment * [skip ci] Update coblocks.pot/coblocks.json files * Minor fix for grabbing style attribute * Introduce CoBlocks Labs (#2350) * modal framework and fix coblocks-settings menu item too * add php logic for conditonals * add in site design and site contents * try test changes * remove superfluous cypress test * style the modal * update @wordpress/interface * attach controls * remove class-rest-api as it was useless * revert interfaces change * add filter to disable coblocks labs * resolve issue with png imports * rename common tests * mock site-design object for jest tests * fix site design global order for tests * minor tweaks * remove filter that enables coblocks labs * style lint tweak * default coblocks labs controls off * use other filter route * match styles * labs controls example * feedback tweaks * tweaks * add back logic for go theme installed * suggested updates * update globals to reference 8889 port * resolve lint error * refactor site design * use PluginSidebar * use yarn instead * use just yarn in the perf test * remove package-lock.json * try bumping package versions * try removing frozen lock file flag * use frozen lock file flag * prevent layout selector is labs is open * add mobile styles * try confirming editor exists first in test * remove filter lock * add simple test for labs * try remove superfluous dispatches * try layout selector settings modal test fix * remove troublesome tests * WPEX-1778 - update coblocks labs with go daddy styling (#2368) * update coblocks labs with go daddy styling * Fix some Cypress tests in WP 6.0 RC1 (#2372) * Fix Alert block cypress test * Fix author block test * Fix typography settings modal test * Fix highlight block test * Fix animation settings modal test * [skip ci] Update coblocks.pot/coblocks.json files Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: GoDaddy Translator Bot <[email protected]> Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: Anthony Ledesma <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: snovosel-godaddy <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: GoDaddy Translator Bot <[email protected]> * [skip ci] Update coblocks.pot/coblocks.json files * GoLF Automated checkin by importer (5/9/2022 10:09:48 AM) * Issue 2305 - add tab index to carousel thumbnails (#2312) * handle tab focus for carousel block thumbnails * deprecate carousel block correctly * undo prop order eslint changes * handle deprecations of gallery carousel * add aria-label to gallery thumbnail * update gallery carousel snapshot Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: snovosel <[email protected]> * [skip ci] Update coblocks.pot/coblocks.json files * Remove tests * regen yarn.lock file Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GoDaddy Translator Bot <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: JR Tashjian <[email protected]> Co-authored-by: Anthony Ledesma <[email protected]> Co-authored-by: snovosel-godaddy <[email protected]> Co-authored-by: GoLF <[email protected]> Co-authored-by: Steve Novosel <[email protected]> Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: snovosel <[email protected]>
jrtashjian
added a commit
that referenced
this pull request
May 10, 2022
* Bump composer/composer from 2.2.11 to 2.2.12 (#2363) Bumps [composer/composer](https://github.com/composer/composer) from 2.2.11 to 2.2.12. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.2.11...2.2.12) --- updated-dependencies: - dependency-name: composer/composer dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [skip ci] Update coblocks.pot/coblocks.json files * Changelog for 2.22.11 * 2.22.11 * [skip ci] Update coblocks.pot/coblocks.json files * Bump grunt from 1.4.1 to 1.5.2 (#2366) Bumps [grunt](https://github.com/gruntjs/grunt) from 1.4.1 to 1.5.2. - [Release notes](https://github.com/gruntjs/grunt/releases) - [Changelog](https://github.com/gruntjs/grunt/blob/main/CHANGELOG) - [Commits](gruntjs/grunt@v1.4.1...v1.5.2) --- updated-dependencies: - dependency-name: grunt dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [skip ci] Update coblocks.pot/coblocks.json files * Migrate dynamic-hr to core/seperator * Remove tests * Add a validation for the presence of the minor part in the version (#2365) * Add validation minor version part * Revert "Add validation minor version part" This reverts commit e578099. * Bump GoDaddy Styles to 0.4.0 * test random branch * publish branch * [skip ci] Update coblocks.pot/coblocks.json files * Fix some Cypress tests in WP 6.0 RC1 (#2372) * Fix Alert block cypress test * Fix author block test * Fix typography settings modal test * Fix highlight block test * Fix animation settings modal test * [skip ci] Update coblocks.pot/coblocks.json files * Fix more Cypress tests for WP 6.0 RC1 (#2373) * Fix logos block test * Fix dynamic separator block test * Fix Click to Tweet block test * Fix settings modal color extension test * [skip ci] Update coblocks.pot/coblocks.json files * Add e2e tests with PHP 8.0 (#2375) * Add e2e tests with PHP 8.1 * TT2 * Only 8.0 is supported for the moment * [skip ci] Update coblocks.pot/coblocks.json files * Introduce CoBlocks Labs (#2350) * modal framework and fix coblocks-settings menu item too * add php logic for conditonals * add in site design and site contents * try test changes * remove superfluous cypress test * style the modal * update @wordpress/interface * attach controls * remove class-rest-api as it was useless * revert interfaces change * add filter to disable coblocks labs * resolve issue with png imports * rename common tests * mock site-design object for jest tests * fix site design global order for tests * minor tweaks * remove filter that enables coblocks labs * style lint tweak * default coblocks labs controls off * use other filter route * match styles * labs controls example * feedback tweaks * tweaks * add back logic for go theme installed * suggested updates * update globals to reference 8889 port * resolve lint error * refactor site design * use PluginSidebar * use yarn instead * use just yarn in the perf test * remove package-lock.json * try bumping package versions * try removing frozen lock file flag * use frozen lock file flag * prevent layout selector is labs is open * add mobile styles * try confirming editor exists first in test * remove filter lock * add simple test for labs * try remove superfluous dispatches * try layout selector settings modal test fix * remove troublesome tests * WPEX-1778 - update coblocks labs with go daddy styling (#2368) * update coblocks labs with go daddy styling * Fix some Cypress tests in WP 6.0 RC1 (#2372) * Fix Alert block cypress test * Fix author block test * Fix typography settings modal test * Fix highlight block test * Fix animation settings modal test * [skip ci] Update coblocks.pot/coblocks.json files Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: GoDaddy Translator Bot <[email protected]> Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: Anthony Ledesma <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: snovosel-godaddy <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: GoDaddy Translator Bot <[email protected]> * [skip ci] Update coblocks.pot/coblocks.json files * GoLF Automated checkin by importer (5/9/2022 10:09:48 AM) * Issue 2305 - add tab index to carousel thumbnails (#2312) * handle tab focus for carousel block thumbnails * deprecate carousel block correctly * undo prop order eslint changes * handle deprecations of gallery carousel * add aria-label to gallery thumbnail * update gallery carousel snapshot Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: snovosel <[email protected]> * [skip ci] Update coblocks.pot/coblocks.json files * Regen yarn.lock file * Restore dynamic-separator front-end styles Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GoDaddy Translator Bot <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: Anthony Ledesma <[email protected]> Co-authored-by: snovosel-godaddy <[email protected]> Co-authored-by: GoLF <[email protected]> Co-authored-by: Steve Novosel <[email protected]> Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: snovosel <[email protected]> Co-authored-by: JR Tashjian <[email protected]>
jrtashjian
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tab focus control to the gallery carousel block
Fixes #2305
Screenshots
Types of changes
Bug fix / accessibility
How has this been tested?
manually
Acceptance criteria
The carousel thumbnails should be able to be tab-able and be able to change the current carousel slide
Checklist: