Migrate dynamic HR to core/separator #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [composer/composer](https://github.com/composer/composer) from 2.2.11 to 2.2.12. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.2.11...2.2.12) --- updated-dependencies: - dependency-name: composer/composer dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [grunt](https://github.com/gruntjs/grunt) from 1.4.1 to 1.5.2. - [Release notes](https://github.com/gruntjs/grunt/releases) - [Changelog](https://github.com/gruntjs/grunt/blob/main/CHANGELOG) - [Commits](gruntjs/grunt@v1.4.1...v1.5.2) --- updated-dependencies: - dependency-name: grunt dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
EvanHerman
requested review from
jrtashjian,
AnthonyLedesma,
jonathanbardo and
olafleur-godaddy
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Performance Test Results:
|
* Fix Alert block cypress test * Fix author block test * Fix typography settings modal test * Fix highlight block test * Fix animation settings modal test
* Fix logos block test * Fix dynamic separator block test * Fix Click to Tweet block test * Fix settings modal color extension test
* Add e2e tests with PHP 8.1 * TT2 * Only 8.0 is supported for the moment
* modal framework and fix coblocks-settings menu item too * add php logic for conditonals * add in site design and site contents * try test changes * remove superfluous cypress test * style the modal * update @wordpress/interface * attach controls * remove class-rest-api as it was useless * revert interfaces change * add filter to disable coblocks labs * resolve issue with png imports * rename common tests * mock site-design object for jest tests * fix site design global order for tests * minor tweaks * remove filter that enables coblocks labs * style lint tweak * default coblocks labs controls off * use other filter route * match styles * labs controls example * feedback tweaks * tweaks * add back logic for go theme installed * suggested updates * update globals to reference 8889 port * resolve lint error * refactor site design * use PluginSidebar * use yarn instead * use just yarn in the perf test * remove package-lock.json * try bumping package versions * try removing frozen lock file flag * use frozen lock file flag * prevent layout selector is labs is open * add mobile styles * try confirming editor exists first in test * remove filter lock * add simple test for labs * try remove superfluous dispatches * try layout selector settings modal test fix * remove troublesome tests * WPEX-1778 - update coblocks labs with go daddy styling (#2368) * update coblocks labs with go daddy styling * Fix some Cypress tests in WP 6.0 RC1 (#2372) * Fix Alert block cypress test * Fix author block test * Fix typography settings modal test * Fix highlight block test * Fix animation settings modal test * [skip ci] Update coblocks.pot/coblocks.json files Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: GoDaddy Translator Bot <[email protected]> Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: Anthony Ledesma <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: snovosel-godaddy <[email protected]> Co-authored-by: Olivier Lafleur <[email protected]> Co-authored-by: GoDaddy Translator Bot <[email protected]>
* handle tab focus for carousel block thumbnails * deprecate carousel block correctly * undo prop order eslint changes * handle deprecations of gallery carousel * add aria-label to gallery thumbnail * update gallery carousel snapshot Co-authored-by: AnthonyLedesma <[email protected]> Co-authored-by: snovosel <[email protected]>
jrtashjian
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate dynamic HR block to
core/separator.Types of changes
New feature (non-breaking change which adds functionality)
How has this been tested?
Manually tested each block and attribute to ensure the blocks migrated without any breaking changes. The new core/separator block height differed from the dynamic HR block, so there are
core/spacerblocks added to try and mimic the same heights. There is a slight difference in spacing due to block margins in the editor.The tests were removed, since the dynamic HR block will no longer be present.
Checklist: