Fix multi-selection doesn't correctly show in the inspector #47851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new CollisionObject gizmo used for custom shapes was used with higher priority due to alphabetical order and was preventing physical bones from being displayed in the editor.
Improved 3D Scene Importer
Add a "keep" import mode to keep files as-is and export them.
…urce_notification_removal Remove translation change notification when setting the locale of a Translation resource
…ames Remove hardcoded names in generated objects
Fix wrong width with PopupMenus on first opening in the editor
Bring the Raycast2D improvements to Rayshape2D
…setting-name Fix feature tag casing in the Windows pen tablet project setting name
…ation Fix translations update in window & Dialogs (AcceptDialog/ConfirmationDialog/FileDialog) (Fix 39320, 39258 & 45887)
…argin-doc More detailed documentation for KinematicBody safe collision margin
…al_t Use real_t in GridMap and VariantParser
Use real_t in 2D nodes
…lation Rename PHashTranslation to OptimizedTranslation
…e-gizmo Fix PhysicalBone gizmo not showing
…r-export-templates Add unit tests for export templates
…hod-order Make the expected method calling order in SurfaceTool more explicit
The moment of inertia calculation for BoxShape is:
```
Vector3(
(p_mass / 3.0) * (ly * ly + lz * lz),
(p_mass / 3.0) * (lx * lx + lz * lz),
(p_mass / 3.0) * (lx * lx + ly * ly));
```
where the final line includes both the x and y extents.
However, for CapsuleShape3D, CylinderShape3D, ConvexPolygonShape3D, ConcavePolygonShape3D, and HeightMapShape3D, the final line read `(p_mass / 3.0) * (extents.y * extents.y + extents.y * extents.y)`. I believe this is a mistake, considering the comment in each case mentions using an AABB approximation, which should follow the same approach as BoxShape.
This change corrects the final line to include both the x and y components of the shape's extent.
…nertia [Godot Physics]: Correct typo in moment of inertia calculations.
Allow to drop files on filtered scene tree
Move duplicated code into a function
…alsense [HTML5] Logitech Dual Action Gamepad FF/Linux
Fix crash on importing empty .fbx file
…n_ui_focus allow input echo when changing ui focus
Main: Default `--doctool` path to '.' if none given
…ix-raw-mode Fix ColorPicker's RGB bars are show in RAW mode and other
ray90514
force-pushed
the
bug#47555
branch
3 times, most recently
from
a227480 to
b0fe599
Compare
The PR should be made for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #47555
Fix selection not correctly showing in the inspector when using shift key select first node or deselecting node until last selection.
The problem also appears in
master.They caused by #32908.