Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3D editor gizmo icons for Decal, LightmapProbe and FogVolume #81554

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Add 3D editor gizmo icons for Decal, LightmapProbe and FogVolume #81554

merged 1 commit into from
Sep 16, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 11, 2023 •
edited
Loading

  • Tweak CPUParticles3D editor gizmo icon to use the same outline color as other gizmo icons. Make the internal icon easier to see by using an orange color instead of gray.

Lightmap probes that are automatically generated by LightmapGI don't have gizmo icons, as these are not nodes in the first place. Only manually authored LightmapProbe nodes have an icon.

Preview

Left: Decal, middle left: CPUParticles3D, middle right: GPUParticles3D, right: LightmapProbe

image

FogVolume:

image

@Calinou Calinou requested a review from a team as a code owner September 11, 2023 21:00
@Calinou Calinou added this to the 4.2 milestone Sep 11, 2023
@Calinou Calinou force-pushed the editor-gizmos-add-decal branch from b2b7f70 to c8a65d3 Compare September 11, 2023 21:16
@Calinou Calinou changed the title Add a 3D editor gizmo icon for Decal Add 3D editor gizmo icons for Decal and LightmapProbe Sep 11, 2023
@jcostello
Copy link
Contributor

@Calinou does it make it selectable with box select too?

@Calinou
Copy link
Member Author

Calinou commented Sep 12, 2023

@Calinou does it make it selectable with box select too?

Yes 🙂

@Calinou Calinou mentioned this pull request Sep 14, 2023
Merged
@Calinou Calinou force-pushed the editor-gizmos-add-decal branch from c8a65d3 to a910357 Compare September 15, 2023 00:08
@Calinou Calinou changed the title Add 3D editor gizmo icons for Decal and LightmapProbe Add 3D editor gizmo icons for Decal, LightmapProbe and FogVolume Sep 15, 2023
@Calinou Calinou force-pushed the editor-gizmos-add-decal branch from a910357 to 7ea4449 Compare September 15, 2023 16:50
MewPurPur
MewPurPur reviewed Sep 15, 2023
View reviewed changes
editor/icons/GizmoCPUParticles3D.svg Outdated Show resolved Hide resolved
editor/icons/GizmoDecal.svg Outdated Show resolved Hide resolved
editor/icons/GizmoFogVolume.svg Outdated Show resolved Hide resolved
editor/icons/GizmoLightmapProbe.svg Outdated Show resolved Hide resolved
@YuriSizov
Copy link
Contributor

@MewPurPur You're brilliant! 🚀

@Calinou @MewPurPur
Add 3D editor gizmo icons for Decal, LightmapProbe and FogVolume
5345cf3 
- Tweak CPUParticles3D editor gizmo icon to use the same outline
  color as other gizmo icons. Make the internal icon easier to see
  by using an orange color instead of gray.

Co-authored-by: MewPurPur <[email protected]>
@Calinou
Copy link
Member Author

Calinou commented Sep 15, 2023

@MewPurPur Thanks a lot! I've added you as a co-author 🙂

@Calinou Calinou force-pushed the editor-gizmos-add-decal branch from 7ea4449 to 5345cf3 Compare September 15, 2023 18:45
@akien-mga akien-mga merged commit 7ca579c into godotengine:master Sep 16, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-gizmos-add-decal branch September 25, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MewPurPur MewPurPur MewPurPur left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:editor topic:3d usability
Projects
None yet
Milestone
4.2
5 participants
@Calinou @jcostello @YuriSizov @akien-mga @MewPurPur