feat: procedure callers respond to models #6718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
feat/procedure-callers-respond-to-models
branch
from
1f9163b to
c53a4a1
Compare
4 tasks
BeksOmega
force-pushed
the
feat/procedure-callers-respond-to-models
branch
from
c53a4a1 to
4e79d35
Compare
BeksOmega
force-pushed
the
feat/procedure-callers-respond-to-models
branch
from
346e097 to
8c688b4
Compare
NeilFraser
approved these changes
Jan 6, 2023
cpcallen
reviewed
Jan 12, 2023
|
|
||
| /** | ||
| * @param {string} name The name of the procedure model to find. | ||
| * @param {string[]} params The param names of the procedure model to find. |
There was a problem hiding this comment.
string[] is not valid Closure type syntax. Do you mean Array<string>?
This provoked a warning from closure-make-deps.
| * Creates a procedure definition block with the given name and params, | ||
| * and returns the procedure model associated with it. | ||
| * @param {string} name The name of the procedure to create. | ||
| * @param {string[]} params The names of the parameters to create. |
|
Can fix! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #6526
Proposed Changes
Refactors the procedure caller blocks to rely on the backing data models.
Reason for Changes
Using the data models makes it so that procedures are explicitly defined!
Test Coverage
Enabled some tests, added some tests, reorganized some tests etc.
Documentation
N/A
Additional Information
Almost certainly best to review this commit-wise haha.
Dependent on #6706