feat: procedure defs deserialize models #6706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: feature
BeksOmega
force-pushed
the
feat/procedure-defs-deserialize-models
branch
from
6b2b455 to
1e168a4
Compare
4 tasks
BeksOmega
force-pushed
the
feat/procedure-defs-deserialize-models
branch
from
1e168a4 to
8b62cf5
Compare
BeksOmega
force-pushed
the
feat/procedure-defs-deserialize-models
branch
2 times, most recently
from
df750eb to
8cb14d4
Compare
gonfunko
reviewed
Jan 5, 2023
gonfunko
approved these changes
Jan 5, 2023
BeksOmega
force-pushed
the
feat/procedure-defs-deserialize-models
branch
from
9cb1f70 to
2b3a2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #6526
Proposed Changes
Makes it so that procedure defs properly deserialize procedure models when they are instantiated.
Reason for Changes
Makes it so the procedures can appear to be implicitly defined (maintaining the previous user-facing behavior).
Test Coverage
Added unit tests for deserialization.
Documentation
N/A
Additional Information
Dependent on #6673