Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the built-in procedure blocks to use the new procedure data models #6526

Closed
BeksOmega opened this issue Oct 10, 2022 · 1 comment · Fixed by #6736
Closed

Refactor the built-in procedure blocks to use the new procedure data models #6526

BeksOmega opened this issue Oct 10, 2022 · 1 comment · Fixed by #6736
Assignees
Labels
component: functions issue: feature request Describes a new feature and why it should be added

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Oct 10, 2022

Problem Statement

For the procedure data models to actually be useful, we need the procedure blocks to use them. Otherwise we just have a vestigial data system with no "views" of the data.

Proposed Solution

See: https://docs.google.com/document/d/1n4MxZQu49mniC7aUtZ1X4xvwWgpL3st4aDU25pwdaNc/edit#heading=h.n4x8mdlhlyyp

@BeksOmega
Copy link
Collaborator Author

BeksOmega commented Nov 21, 2022

I'm going to be tackling this over several steps:

  • Reorganize the procedure blocks to use JSON + Extensions so that it is easier to override / extend / manage individual parts of the blocks' functionality.
  • Make procedure definitions hold an internal ProcedureModel which they update.
  • Update the procedure definitions to actually update themselves based on their ProcedureModel rather than their current properties.
  • Update procedure serialization to get / create ProcedureModels
  • Get rid of the old non-ProcedureModel code.

Then I'll want to do a similar thing for the procedure call blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: functions issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant