Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

1192 Update bundled OpenJPEG to v2.3.1 to fix regression in v2.3.0 #1268

Closed
wants to merge 12 commits into from
Closed

1192 Update bundled OpenJPEG to v2.3.1 to fix regression in v2.3.0 #1268

wants to merge 12 commits into from

Conversation

tst-jlarocco
Copy link
Contributor

@tst-jlarocco tst-jlarocco commented Apr 10, 2019 •
edited by tst-rwildes
Loading

fixes #1192

tst-rwildes and others added 10 commits March 27, 2019 16:52
@tst-rwildes
start of 5.3.1
463c5ac
@tst-rwildes
change version files over to 5.3.1 (#1247)
7b90386
@tst-rwildes
I1246 create 5.3.1 doc folder from copy of 5.3.0 doc folder (#1248)
ffb8f26 
* create new 5.3.1 doc folder from copy of 5.3.0 doc folder.  Nothing hooked up yet just creating initial copy
@tst-rwildes
link up 5.3.1 doc folder (#1249)
5a6b843 
* link up 5.3.1 doc folder
@tst-ccamp
Issue #1255 - Limits internal version string to 3 parts to fix variou…
6a201d9 
…s errors with patch releases (#1256)
@tst-ccamp
Merge pull request #1260 from google/release_5.2.5.2
2af65ff 
Issue #1255 - Limits internal version string to 3 parts - Merge to master
@tst-rwildes
Merge pull request #1261 from google/release_5.3.0
c18f05d 
Merging in Release 5.3.0
@Amndeep7 @tst-ccamp
Copy uninstall scripts (#1232)
a16e2d2 
* Added copying uninstall scripts to the install staging directory (#303)
* Fixed bug causing SCons to have an InternalError (#303)
* Changed the temp staging area subdirectory for storing the uninstall scripts along with also copying over their dependency (#303)
* Added the uninstall scripts being copied from the staging area to the install directory (#303)
* Added version.txt to the set of files that need to be copied over on install so as to allow the uninstall scripts to state the version of the product (#303)
@tst-ccamp
[WIP] Resolve issue #798 - investigate Qt build performance (#1245)
0649d69 
Summary:
Qt build investigated, negligible performance impact gained from excluding non-critical code
@tst-jlarocco
1192 Update bundled OpenJPEG to v2.3.1 to fix regression in v2.3.0
b7729d7
@googlebot googlebot added the cla: yes Manual verification that all contributors have signed the CLA. label Apr 10, 2019
tst-blaird
tst-blaird approved these changes Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@tst-blaird tst-blaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Only code reviewed -- did not test.

@tst-rwildes tst-rwildes changed the base branch from master to release_5.3.0 April 11, 2019 14:51
@tst-rwildes tst-rwildes added this to the 5.3.0 milestone Apr 11, 2019
tst-nfarah-zz
tst-nfarah-zz suggested changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@tst-nfarah-zz tst-nfarah-zz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document the fixed bug in 5.3.0 release notes (docs/geedocs/5.3.0/answer/7160007.html)

tst-rwildes
tst-rwildes approved these changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@tst-rwildes tst-rwildes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed regression testing. Approving this so we can get it into next RC where more testing will be done.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes Manual verification that all contributors have signed the CLA. labels Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tst-nfarah-zz tst-nfarah-zz tst-nfarah-zz requested changes

@tst-blaird tst-blaird tst-blaird approved these changes

@tst-rwildes tst-rwildes tst-rwildes approved these changes

Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tst-jlarocco @googlebot @tst-nfarah-zz @tst-rwildes @tst-blaird @tst-ccamp @Amndeep7