This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Pass the entire optional parameters to createStub #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow additional grpc parameters for constructing Client. Fix googleapis/gax-nodejs#107
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
=========================================
Coverage 85.17% 85.17%
Complexity 3484 3484
=========================================
Files 366 366
Lines 13856 13856
Branches 1576 1576
=========================================
Hits 11802 11802
Misses 1597 1597
Partials 457 457Continue to review full report at Codecov.
|
landrito
reviewed
Feb 22, 2017
There was a problem hiding this comment.
Same question as googleapis/gax-nodejs#113 (comment).
It looks like servicePath and port will be passed into this createStub twice (explicitly as parameters and implicitly as options). Is there a good way to minimize this repetition?
landrito
approved these changes
Feb 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow additional grpc parameters for constructing Client.
Fix googleapis/gax-nodejs#107