Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying optional parameters for gRPC #107

Closed
jmuk opened this issue Feb 16, 2017 · 0 comments
Closed

Allow specifying optional parameters for gRPC #107

jmuk opened this issue Feb 16, 2017 · 0 comments
Assignees
@jmuk
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@jmuk
Copy link
Contributor

jmuk commented Feb 16, 2017

Right now GAX only passes the address and the channel credentials to create a new client (see https://github.com/googleapis/gax-nodejs/blob/master/lib/grpc.js#L160). However, gRPC's client constructor accepts the third optional parameter to customize various things (https://github.com/grpc/grpc/blob/master/src/node/src/client.js#L732). GAX should allow accepting the options.

See also googleapis/google-cloud-node#1991
@jmuk jmuk mentioned this issue Feb 16, 2017
Closed
jmuk added a commit to jmuk/toolkit that referenced this issue Feb 21, 2017
@jmuk
Pass the entire optional parameters to createStub
b576ed1 
To allow additional grpc parameters for constructing Client.
Fix googleapis/gax-nodejs#107
@jmuk jmuk mentioned this issue Feb 21, 2017
Merged
jmuk added a commit to jmuk/toolkit that referenced this issue Feb 21, 2017
@jmuk
Pass the entire optional parameters to createStub
1a740a1 
To allow additional grpc parameters for constructing Client.
Fix googleapis/gax-nodejs#107
@jmuk jmuk mentioned this issue Feb 21, 2017
Merged
jmuk added a commit to googleapis/gapic-generator that referenced this issue Feb 22, 2017
@jmuk
Pass the entire optional parameters to createStub (#1050)
3e4574e 
To allow additional grpc parameters for constructing Client.
Fix googleapis/gax-nodejs#107
@graphicore graphicore mentioned this issue Dec 17, 2017
Closed
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmuk jmuk

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmuk @yoshi-automation