Pass through options to grpc client creation. #113
Conversation
With toolkit changes, this allows customizing grpc behaviors. See: - googleapis/google-cloud-node#1991 - googleapis/google-cloud-node#1905
lib/grpc.js
Outdated
| return new CreateStub(serviceAddress, credentials); | ||
| var grpcOptions = {}; | ||
| Object.keys(options).forEach(function(key) { | ||
| if (key.indexOf('grpc.') == 0) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lib/grpc.js
Outdated
| @@ -148,7 +148,8 @@ GrpcClient.prototype.constructSettings = function constructSettings( | |||
| * @param {number} port - The port of the service. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 91.08% 92.27% +1.19%
==========================================
Files 11 11
Lines 1279 1282 +3
Branches 257 257
==========================================
+ Hits 1165 1183 +18
+ Misses 114 99 -15
Continue to review full report at Codecov.
|
|
PTAL |
test/grpc.js
Outdated
| combineChannelCredentials: sinon.stub(), | ||
| createFromGoogleCredential: sinon.stub() | ||
| }}; | ||
| var dummyAuth = {authData: 'dummy'}; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
With toolkit changes, this allows customizing grpc behaviors.
See:
updates #107