Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC max size limit #1991

Closed
pyhrus opened this issue Feb 14, 2017 · 7 comments · Fixed by #2007
Closed

gRPC max size limit #1991

pyhrus opened this issue Feb 14, 2017 · 7 comments · Fixed by #2007
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@pyhrus
Copy link

pyhrus commented Feb 14, 2017

Since grpc version 1.0.0, message size is limit 4MB, and pubsub itself supports payload size upto 10MB. If there is message that is greater than 4MB in queue, pubsub client errors out with Error: Received message larger than max (6374241 vs. 4194304)

Environment details

  • OS: Debian Jessie
  • Node.js version: 6.3.1
  • npm version:3.10.3
  • google-cloud-node version: 0.8.0

Steps to reproduce

  1. Publish message greater than 4MB using HTTP API
  2. Use pubsub client to pull the message

Thanks!

@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Feb 14, 2017
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Feb 16, 2017

@murgatroid99 @jmuk do you know if there's a way to handle this?

@jmuk
Copy link
Contributor

jmuk commented Feb 16, 2017

It's really obscure to me how to customize the parameters like this. Maybe the third parameter to the Client constructor might be used (https://github.com/grpc/grpc/blob/master/src/node/src/client.js#L732) but I don't know what values or structures can configure this.

@murgatroid99, do you know which keys/values we should use here?

@murgatroid99
Copy link

The keys and values are defined at https://github.com/grpc/grpc/blob/master/include/grpc/impl/codegen/grpc_types.h#L148. The one you want for this case is "grpc.max_send_message_length".

@jmuk
Copy link
Contributor

jmuk commented Feb 16, 2017

Thanks!

I also filed googleapis/gax-nodejs#107 for this problem.

@stephenplusplus
Copy link
Contributor

PR sent to remove the limit of the max message sent length and max message received length: #2007

jmuk added a commit to jmuk/gax-nodejs that referenced this issue Feb 21, 2017
jmuk added a commit to googleapis/gax-nodejs that referenced this issue Feb 22, 2017
@arbesfeld
Copy link
Contributor

We still seem to be hitting this 4mb limit while testing with the following versions:

    "@google-cloud/bigtable": "0.10.1",
    "@google-cloud/pubsub": "0.11.0",
    "@google-cloud/storage": "1.1.0"

Any recommendation for how to avoid this GRPC limit?

@Michael-Jing
Copy link

I am using the grpcio python lib, and encounter the same issue, any idea to get rid of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants