Fix Hardware Key Login in Teleport Connect #46793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
nklaassen
approved these changes
Sep 20, 2024
gzdunek
approved these changes
Sep 20, 2024
public-teleport-github-review-bot
bot
removed request for
smallinsky and
fheinecke
Joerger
deleted the
joerger/fix-hardware-key-support-teleport-connect
branch
Joerger
added a commit
that referenced
this pull request
Oct 7, 2024
* Reuse tc.NewSSHLogin in Teleport Connect for consistency. * reuse sso login function.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Fix Hardware Key Login in Teleport Connect (#46793) * Reuse tc.NewSSHLogin in Teleport Connect for consistency. * reuse sso login function. * SSO Ceremony refactor (#46983) * Refactor SSO redirector for customization; add SSO MFA ceremony to redirector. * Add customizable SSO ceremony. * Create SSO login ceremony from client; Remove ProxySupportsKeyPolicyMessage for v17. * Resolve comments. * Refactor redirector closing. * Add redirector tests. * Add ceremony and redirector tests. * Fix new copyright headers. * Use slog. * Fix lint. * Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tls/ssh attestation statement changes in #45995 were not applied to the Teleport Connect login. This PR fixes hardware key login by including those changes.
Note: Hardware key Support is in an unstable state in Teleport Connect due PIV connection contention. Fixing this issue, and adding PIN support, is in progress - #46728. The caching fix alone should be enough to fix the
hardware_keysetting and in many cases thehardware_key_touchsetting.