Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] SSO Ceremony refactor #47303

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Oct 7, 2024

Backport #46793 and #46983 to branch/v16

* Reuse tc.NewSSHLogin in Teleport Connect for consistency.

* reuse sso login function.
* Refactor SSO redirector for customization; add SSO MFA ceremony to redirector.

* Add customizable SSO ceremony.

* Create SSO login ceremony from client; Remove ProxySupportsKeyPolicyMessage for v17.

* Resolve comments.

* Refactor redirector closing.

* Add redirector tests.

* Add ceremony and redirector tests.

* Fix new copyright headers.

* Use slog.

* Fix lint.
@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Oct 7, 2024
@github-actions github-actions bot added backport size/md tctl tctl - Teleport admin tool labels Oct 7, 2024
@github-actions github-actions bot requested review from gzdunek and nklaassen October 7, 2024 22:32
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from nklaassen October 9, 2024 19:17
@Joerger Joerger enabled auto-merge October 9, 2024 19:17
@Joerger Joerger added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 16, 2024
@Joerger Joerger enabled auto-merge October 16, 2024 20:02
@Joerger Joerger added this pull request to the merge queue Oct 16, 2024
Merged via the queue into branch/v16 with commit c9f7f5f Oct 16, 2024
39 checks passed
@Joerger Joerger deleted the joerger/v16/sso-ceremony-refactor branch October 16, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/md tctl tctl - Teleport admin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants