SSO Ceremony refactor #46983
Merged
SSO Ceremony refactor #46983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
no-changelog
bernardjkim
approved these changes
Sep 30, 2024
Joerger
force-pushed
the
joerger/sso-ceremony-refactor
branch
from
5fafe17 to
a45a181
Compare
Closed
Joerger
force-pushed
the
joerger/sso-ceremony-refactor
branch
2 times, most recently
from
6f3aff5 to
687f23d
Compare
Joerger
force-pushed
the
joerger/sso-ceremony-refactor
branch
from
a7dc319 to
3ebb7f7
Compare
strideynet
approved these changes
Oct 7, 2024
Joerger
added a commit
that referenced
this pull request
Oct 7, 2024
* Refactor SSO redirector for customization; add SSO MFA ceremony to redirector. * Add customizable SSO ceremony. * Create SSO login ceremony from client; Remove ProxySupportsKeyPolicyMessage for v17. * Resolve comments. * Refactor redirector closing. * Add redirector tests. * Add ceremony and redirector tests. * Fix new copyright headers. * Use slog. * Fix lint.
|
Skipping v15 backport for now, as part of #39899 would need to be backported as well. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Fix Hardware Key Login in Teleport Connect (#46793) * Reuse tc.NewSSHLogin in Teleport Connect for consistency. * reuse sso login function. * SSO Ceremony refactor (#46983) * Refactor SSO redirector for customization; add SSO MFA ceremony to redirector. * Add customizable SSO ceremony. * Create SSO login ceremony from client; Remove ProxySupportsKeyPolicyMessage for v17. * Resolve comments. * Refactor redirector closing. * Add redirector tests. * Add ceremony and redirector tests. * Fix new copyright headers. * Use slog. * Fix lint. * Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SSO Ceremony so it can be useful outside of the single CLI login flow it is currently built for. Specifically, this new SSO ceremony can easily be modified for SSO MFA.
This PR should have no functional impact.