Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 Transfer assessment #848

Merged
merged 30 commits into from
Feb 10, 2025
Merged

2024 Transfer assessment #848

merged 30 commits into from
Feb 10, 2025

Conversation

eanders
Copy link
Contributor

@eanders eanders commented Aug 16, 2024

Please squash merge this PR

Description

This adds the 2024 version of the non-HMIS client transfer assessment and updates the sync logic for non-HMIS assessments -> clients

Type of change

  • New feature (adds functionality)

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (rubocop)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

Sorry, something went wrong.

@eanders eanders requested a review from dtgreiner August 16, 2024 14:30
@eanders eanders marked this pull request as draft August 16, 2024 16:23
@eanders
Copy link
Contributor Author

eanders commented Aug 16, 2024

Moving to draft until we have timing of launch determined.

Base automatically changed from release-64 to stable October 4, 2024 11:31
@eanders eanders changed the base branch from stable to release-72 December 30, 2024 14:52
* WIP: stubs for family pathways

* WIP; changes to family pathways

* WIP; most questions for family pathways

* WIP

* Non-HMIS Pathways

* Expose first date homeless on pathways client view

* Update Pathways and Families Pathways assessments to collect first date homeless

* Update tie breaker calculation for pathways assessments

* WIP; Family PSH prioritization scheme

* Tests for Family PSH prioritization

* New prioritization schemes
@eanders eanders changed the base branch from release-72 to release-73 January 22, 2025 13:34
@eanders eanders marked this pull request as ready for review February 8, 2025 20:28
@eanders eanders requested a review from dtgreiner February 8, 2025 20:28
@eanders
Copy link
Contributor Author

eanders commented Feb 8, 2025

@dtgreiner we're ready to merge this, but it could use another set of eyes as a bunch has changed since you last looked.

@eanders eanders changed the base branch from release-73 to release-74 February 8, 2025 21:00
},
psh_required: {
title: 'In need of Permanent Supportive Housing',
type: 'String',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need description: nil here too?

}
{}.tap do |options|
options[pathways_assessment_type] = { title: pathways_title, description: pathways_description }
options[family_pathways_assessment_type] = { title: family_pathways_title, description: family_pathways_description } unless Rails.env.production?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was unless Rails.env.production? left over in case this went out to production earlier, or is it intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a comment, that's there to allow launching the Transfer assessment prior to the family assessment in production. It will be removed in the near future.

Comment on lines +92 to +93
profiles:
- manual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't expecting a docker-compose change. I don't see any issues with it, but making sure it was meant to be included here and not in the override

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was breaking my local environment. I confirmed with @yakloinsteak, it should not be an issue to include.

@eanders eanders merged commit da829fe into release-74 Feb 10, 2025
17 checks passed
@eanders eanders deleted the ea/transfer-2024 branch February 10, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants