Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please test with broken HTTP/2 stream IDs #104

Closed
vjpai opened this issue Mar 6, 2015 · 3 comments · Fixed by #6940
Closed

Please test with broken HTTP/2 stream IDs #104

vjpai opened this issue Mar 6, 2015 · 3 comments · Fixed by #6940
Labels
fixit P2 Status: Help Wanted Type: Testing

Comments

@vjpai
Copy link
Member

vjpai commented Mar 6, 2015

Hi there,
We recently got hit in C with a crash that happened when HTTP/2 stream IDs went unexpected (violating the invariant of increase on a connection) and also aren't prepared for the situation where we approach or cross max stream id (0x7fffffffu). Please check that this case works in Go. If you need some client code to test that, I can let you use the client code that was sent to me.
This is related to C issues: grpc/grpc#946 and grpc/grpc#957

Thanks!
Vijay
@iamqizhao
Copy link
Contributor

Thanks. I think bradfitz/http2 has handled this but I need to verify and see whether grpc handles it appropriately.

bradfitz added a commit to bradfitz/grpc-go that referenced this issue Jan 31, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
a06f8f0 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
a4a61af 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
@bradfitz bradfitz mentioned this issue Feb 1, 2016
Merged
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
20d0619 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
85d0357 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
31ff71d 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
eeff984 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
e836862 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 5, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
1e2a9c2 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 8, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
737fff1 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
cc3cd51 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
d1f014c 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
fc6ebf5 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
8c9ca55 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 10, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
61d3357 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
eb0e517 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
81d512c 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
d0f39dd 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 12, 2016
@bradfitz
Add a ServeHTTP method to *grpc.Server
7346c87 
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
@menghanl menghanl added the TODO label Jun 16, 2017
@dfawley dfawley removed the TODO label Aug 24, 2017
@dfawley dfawley added the fixit label May 3, 2021
@easwars
Copy link
Contributor

easwars commented Sep 21, 2023 •
edited
Loading

Draining of client transport when the streamID approaches MaxStreamID was handled here: #5889. It contains a test for this scenario as well.

@easwars
Copy link
Contributor

easwars commented Sep 21, 2023 •
edited
Loading

We have checks on the server for validating the incoming stream ID here: https://github.com/grpc/grpc-go/blob/master/internal/transport/http2_server.go#L369, but I can't seem to find tests for this.

@AnandInguva AnandInguva mentioned this issue Jan 24, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
fixit P2 Status: Help Wanted Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add test for invalid streamID AnandInguva/grpc-go
7 participants
@menghanl @easwars @ginayeh @vjpai @iamqizhao @arvindbr8 @dfawley