Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP-level server-side authentication #495

Closed
nodirt opened this issue Jan 20, 2016 · 5 comments
Closed

HTTP-level server-side authentication #495

nodirt opened this issue Jan 20, 2016 · 5 comments

Comments

@nodirt
Copy link

nodirt commented Jan 20, 2016

Is there a plan to support HTTP-level authentication, such as OAuth? The currently existing credentials.TransportAuthenticator supports transport-level authentication (works at net.Conn level). However in order to perform OAuth authentication, one needs access to HTTP headers ("Authorization" header).

@iamqizhao
Copy link
Contributor

@nodirt
Copy link
Author

nodirt commented Jan 20, 2016

oauth.go implements client-side oauth, while this bug is about server-side oauth. In other words, the code that reads "Authorization" HTTP header, communicates to an authority to verify the access token and puts a peer.Peer to the context.

@nodirt nodirt changed the title HTTP-level authentication HTTP-level server-side authentication Jan 20, 2016
@iamqizhao iamqizhao reopened this Jan 20, 2016
@iamqizhao
Copy link
Contributor

yup, some hook need to be added so that the token can be verified. We have not fleshed out the design. Do you have proposal here? :)

@nodirt
Copy link
Author

nodirt commented Jan 20, 2016

Basically we need to be able to inject something like

type MetadataAuthenticator interface {
    // AuthFromMetadata validates metadata and returns AuthInfo.
    // May block.
    AuthFromMetadata(md metadata.MD) (AuthInfo, error)  
}

to grpc.Server, so it calls AuthFromMetadata with the metadata parsed from request headers. On success, puts AuthInfo to the peer.Peer in context. Otherwise reply with HTTP 401.

However, I am not sure

  • whether this should happen sometime in the beginning of a HTTP2 request on every stream. Probably once.
  • why credentials.TransportAuthenticator has to implement credentials.Credentials. GetRequestMetadata has nothing to do with server-side authentication. IMO this part of the design should be revisited, maybe client- and server- authentication should be split. To me grpc.Creds func is confusing (as a server owner, I want to check creds of clients, not provide creds) and should be renamed to something like Auth that accepts an interface for server-side authentication.

bradfitz added a commit to bradfitz/grpc-go that referenced this issue Jan 31, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 1, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
@iamqizhao
Copy link
Contributor

Merging this to #240 which I am actively working on.

bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 4, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 5, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 8, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 9, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 10, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 11, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
bradfitz added a commit to bradfitz/grpc-go that referenced this issue Feb 12, 2016
This adds new http.Handler-based ServerTransport in the process,
reusing the HTTP/2 server code in x/net/http2 or Go 1.6+.

All end2end tests pass with this new ServerTransport.

Fixes grpc#75

Also:
Updates grpc#495 (lets user fix it with middleware in front)
Updates grpc#468 (x/net/http2 validates)
Updates grpc#147 (possible with x/net/http2)
Updates grpc#104 (x/net/http2 does this)
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants