forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[VisLibrary] AnnotGroup listing page papercuts (elastic#205914)
## Summary This PR fixes [Annotation groups Listing Page Papercuts](elastic#198731) and [Dashboard Listing Page Papercuts](elastic#198728) issues. 1. Changed the name of the first column 2. Fixed edit icon being invisible while editing functionality is available. In the past the logic was different - hiding of icon was happening based on `isEditable(item)` property, and in the [[Managed content] readonly in library views](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552) PR the logic was changed to depend on adding a key `{ edit: { enabled: false }` if there is a need to hide the Edit button. What happened is that the logic should be -> If you don't want to show the Edit icon, add `{ edit: { enabled: false }`, but in the current code, although there is no such key, the pencil stays invisible, because the `Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to `false` when it is `undefined` (when the Edit functionality isn't disabled.) In this PR I propose an adjustment to this line of code. 3. Changed the View Details icon. 4. Show Reload page toast when a user changes preferred `savedObjects:perPage` in Advanced Settings. 5. Fix sorting algorithm that was sorting incorrectly if the preferred `savedObjects:perPage` was less than 10. <img width="237" alt="Screenshot 2025-01-09 at 13 44 39" src="https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9" /> <img width="243" alt="Screenshot 2025-01-09 at 13 43 30" src="https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd" />
- Loading branch information
1 parent
3d82bb5
commit 86e8a2f
Showing
5 changed files
with
6 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters