eth_feeHistory invalid cached response #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 73.88% // Head: 73.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 73.88% 73.91% +0.02%
==========================================
Files 29 29
Lines 1815 1817 +2
Branches 336 338 +2
==========================================
+ Hits 1341 1343 +2
Misses 375 375
Partials 99 99
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Nana-EC
approved these changes
Feb 7, 2023
Nana-EC
approved these changes
Feb 10, 2023
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Fix cache Signed-off-by: nikolay <[email protected]> * Fix unit test Signed-off-by: nikolay <[email protected]> --------- Signed-off-by: nikolay <[email protected]>
2 tasks
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Fix cache Signed-off-by: nikolay <[email protected]> * Fix unit test Signed-off-by: nikolay <[email protected]> --------- Signed-off-by: nikolay <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Nana-EC
added a commit
that referenced
this pull request
Feb 15, 2023
Cherry pick PRs that went into main branch since cutting a 0.18.0-alpha1. PRs map to individual commits - [PR 882 - eth_feeHistory invalid cached response](#882) - [PR 887 - Needed changes for metrics improvements](#887) - [PR 883 - Handle GRPC timeout error](#883) - PR 898 - update-logs-and-metrics Added the requestId to the server context](#898) --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> --------- Signed-off-by: nikolay <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: Alfredo Gutierrez <[email protected]> Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: ebadiere <[email protected]> Co-authored-by: Nikolay Atanasow <[email protected]> Co-authored-by: Alfredo Gutierrez <[email protected]> Co-authored-by: Ivo Yankov <[email protected]> Co-authored-by: Eric Badiere <[email protected]>
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Fix cache Signed-off-by: nikolay <[email protected]> * Fix unit test Signed-off-by: nikolay <[email protected]> --------- Signed-off-by: nikolay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nikolay [email protected]
Description:
Related issue(s):
Fixes #881
Notes for reviewer:
Checklist