865-update-logs-and-metrics. Added the requestId to the server context. #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.75% // Head: 74.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 74.75% 74.41% -0.34%
==========================================
Files 29 28 -1
Lines 1838 1841 +3
Branches 344 348 +4
==========================================
- Hits 1374 1370 -4
- Misses 367 371 +4
- Partials 97 100 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Nana-EC
previously approved these changes
Feb 15, 2023
| @@ -134,11 +135,48 @@ app.getKoaApp().use(async (ctx, next) => { | |||
| } | |||
| }); | |||
|
|
|||
| app.getKoaApp().use(async (ctx, next) => { | |||
There was a problem hiding this comment.
Let's look to rework this method next sprint.
Could see readability and testability improvements
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
ebadiere
force-pushed
the
865-update-logs-and-metrics
branch
from
40370de to
1f8e64b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Feb 15, 2023
Nana-EC
added
enhancement
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
…t. (#898) * 865-update-logs-and-metrics. Added the requestId to the server context. Signed-off-by: ebadiere <[email protected]> * Added missing formatters.ts file. Signed-off-by: ebadiere <[email protected]> * Updated year in copyright. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]>
2 tasks
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
…t. (#898) * 865-update-logs-and-metrics. Added the requestId to the server context. Signed-off-by: ebadiere <[email protected]> * Added missing formatters.ts file. Signed-off-by: ebadiere <[email protected]> * Updated year in copyright. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Nana-EC
added a commit
that referenced
this pull request
Feb 15, 2023
Cherry pick PRs that went into main branch since cutting a 0.18.0-alpha1. PRs map to individual commits - [PR 882 - eth_feeHistory invalid cached response](#882) - [PR 887 - Needed changes for metrics improvements](#887) - [PR 883 - Handle GRPC timeout error](#883) - PR 898 - update-logs-and-metrics Added the requestId to the server context](#898) --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> --------- Signed-off-by: nikolay <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: Alfredo Gutierrez <[email protected]> Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: ebadiere <[email protected]> Co-authored-by: Nikolay Atanasow <[email protected]> Co-authored-by: Alfredo Gutierrez <[email protected]> Co-authored-by: Ivo Yankov <[email protected]> Co-authored-by: Eric Badiere <[email protected]>
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
…t. (#898) * 865-update-logs-and-metrics. Added the requestId to the server context. Signed-off-by: ebadiere <[email protected]> * Added missing formatters.ts file. Signed-off-by: ebadiere <[email protected]> * Updated year in copyright. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies rate limited logs in order to include the requestId in a standard log message.
Adds a Koa requestId package that supports storing the requestId in the application context.
Fixes #885
Notes for reviewer:
Provides the request ID in the logs right as the rateLimit for a given IP is triggered, in the standard log format.
Existing tests cover rateLimited requests.