Needed changes for metrics improvements #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts in milliseconds, default values were [0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10] that makes sense if observations where made in seconds, but we are doing observations in ms and changed them to [5, 10, 25, 50, 100, 250, 500, 1000, 2500, 5000, 10000]. Removed the decrement of gauge since we already have a collect method that is collecting the current balance, for calculating costs we should use consensusNodeClientHistorgram Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
866-improve-metrics
branch
from
3d9b4a4 to
4277aa1
Compare
… Metric and added Counter to keep track of HbarLimiter metrics Signed-off-by: Alfredo Gutierrez <[email protected]>
Codecov ReportBase: 74.16% // Head: 74.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 74.16% 74.33% +0.16%
==========================================
Files 29 29
Lines 1827 1835 +8
Branches 339 341 +2
==========================================
+ Hits 1355 1364 +9
+ Misses 374 373 -1
Partials 98 98
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Good catch on bucketing by seconds vs milliseconds! |
Nana-EC
requested changes
Feb 11, 2023
Nana-EC
added
enhancement
Signed-off-by: Alfredo Gutierrez <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Added buckets with more meaningful values in the context of api requests in milliseconds, default values were [0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10] that makes sense if observations where made in seconds, but we are doing observations in ms and changed them to [5, 10, 25, 50, 100, 250, 500, 1000, 2500, 5000, 10000]. Removed the decrement of gauge since we already have a collect method that is collecting the current balance, for calculating costs we should use consensusNodeClientHistorgram * Metric improvements changed Gauge for Counter used on IP Rate Limiter Metric and added Counter to keep track of HbarLimiter metrics --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
2 tasks
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Added buckets with more meaningful values in the context of api requests in milliseconds, default values were [0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10] that makes sense if observations where made in seconds, but we are doing observations in ms and changed them to [5, 10, 25, 50, 100, 250, 500, 1000, 2500, 5000, 10000]. Removed the decrement of gauge since we already have a collect method that is collecting the current balance, for calculating costs we should use consensusNodeClientHistorgram * Metric improvements changed Gauge for Counter used on IP Rate Limiter Metric and added Counter to keep track of HbarLimiter metrics --------- Signed-off-by: Alfredo Gutierrez <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Nana-EC
added a commit
that referenced
this pull request
Feb 15, 2023
Cherry pick PRs that went into main branch since cutting a 0.18.0-alpha1. PRs map to individual commits - [PR 882 - eth_feeHistory invalid cached response](#882) - [PR 887 - Needed changes for metrics improvements](#887) - [PR 883 - Handle GRPC timeout error](#883) - PR 898 - update-logs-and-metrics Added the requestId to the server context](#898) --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> --------- Signed-off-by: nikolay <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: Alfredo Gutierrez <[email protected]> Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: ebadiere <[email protected]> Co-authored-by: Nikolay Atanasow <[email protected]> Co-authored-by: Alfredo Gutierrez <[email protected]> Co-authored-by: Ivo Yankov <[email protected]> Co-authored-by: Eric Badiere <[email protected]>
Nana-EC
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Added buckets with more meaningful values in the context of api requests in milliseconds, default values were [0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10] that makes sense if observations where made in seconds, but we are doing observations in ms and changed them to [5, 10, 25, 50, 100, 250, 500, 1000, 2500, 5000, 10000]. Removed the decrement of gauge since we already have a collect method that is collecting the current balance, for calculating costs we should use consensusNodeClientHistorgram * Metric improvements changed Gauge for Counter used on IP Rate Limiter Metric and added Counter to keep track of HbarLimiter metrics --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR defines bucket ranges for the histogram of the following metrics:
-rpc_relay_mirror_response
-rpc_relay_method_response
from using the default bucket values of [0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10] that are measuring latency in seconds to [5, 10, 25, 50, 100, 250, 500, 1000, 2500, 5000, 10000] that are measuring latency in milliseconds, witch is the unit of the observations taken.
And also removed line that decreases the gauge (operatorAccountGauge), that its purpose is to have visibility to the costs per account, but that is also being tracker by rpc_relay_consensusnode_response. So better remove to decrease complexity, unneeded redundancy.
Related issue(s):
#866
Fixes #866
Notes for reviewer:
Current Metrics with old buckets:
After this PR:
Current Gauge Metrics:
After this PR:
After this PR:
Newly created metric for hbarLimiter is working as expected
Checklist