ci: Fix changelog-checker GHA workflow #14842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eculver
added
the
pr/no-changelog
github-actions
bot
added
the
theme/contributing
huikang
approved these changes
Oct 3, 2022
DanStough
approved these changes
Oct 3, 2022
eculver
added a commit
that referenced
this pull request
Oct 3, 2022
eculver
added a commit
that referenced
this pull request
Oct 3, 2022
eculver
added a commit
that referenced
this pull request
Oct 3, 2022
eculver
added a commit
that referenced
this pull request
Oct 3, 2022
eculver
added a commit
that referenced
this pull request
Oct 4, 2022
Co-authored-by: Evan Culver <[email protected]>
eculver
added a commit
that referenced
this pull request
Oct 4, 2022
Co-authored-by: Evan Culver <[email protected]>
eculver
added a commit
that referenced
this pull request
Oct 4, 2022
Co-authored-by: Evan Culver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was recently working on some manual backports for 1.11 in #14828 and others and the
changelog-checkerworkflow was failing despite having added a proper changelog entry. When I looked into it, it seems that there is some broken shell code in the action that is making it fail for the case where the base is not the default branch. In my case, the base branch wasrelease/1.11.x.Some history: it looks like back in #10844, there was a bit of a refactor/update to the checker logic that added this default branch case. I guess we just missed the bug in the code review.
In any case, this should fix it!
Testing & Reproduction steps
I tested this by pulling the body of the checker out into a shell script and manually running it with the arguments for my pull request. The contents of the script are here in case you want to try it yourself: https://gist.github.com/eculver/ff83d81e09e5e030f817cf6212c6951f
It should exit 0 on a successful run and output (along with some other debug output)