Backport of ci: Fix changelog-checker GHA workflow into release/1.12.x #14849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/eculver/fix-changelog-checker/curiously-allowing-jawfish
branch
from
b40f694 to
fdf884e
Compare
github-actions
bot
added
the
theme/contributing
eculver
force-pushed
the
backport/eculver/fix-changelog-checker/curiously-allowing-jawfish
branch
from
fdf884e to
d52c971
Compare
eculver
added
the
pr/no-changelog
eculver
approved these changes
Oct 4, 2022
eculver
deleted the
backport/eculver/fix-changelog-checker/curiously-allowing-jawfish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14842 to be assessed for backporting due to the inclusion of the label backport/1.12.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
I was recently working on some manual backports for 1.11 in #14828 and others and the
changelog-checkerworkflow was failing despite having added a proper changelog entry. When I looked into it, it seems that there is some broken shell code in the action that is making it fail for the case where the base is not the default branch. In my case, the base branch wasrelease/1.11.x.Some history: it looks like back in #10844, there was a bit of a refactor/update to the checker logic that added this default branch case. I guess we just missed the bug in the code review.
In any case, this should fix it!
Testing & Reproduction steps
I tested this by pulling the body of the checker out into a shell script and manually running it with the arguments for my pull request. The contents of the script are here in case you want to try it yourself: https://gist.github.com/eculver/ff83d81e09e5e030f817cf6212c6951f
It should exit 0 on a successful run and output (along with some other debug output)
Overview of commits