Update containers API version from 2024-05-01 to 2024-09-01

[tiesmaster]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This is a precursor PR for issue #27243, to update the .../containerservice/{2024-05-01 -> 2024-09-01}/* API. This is to prepare to add support for controlling AKS Advanced Container Networking Services.

I've ran the unittest suite, and the following acceptance test: TestAccKubernetesCluster_runCommand, and all passed.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

---

❗ As this is a version bump of the one of the APIs, the rest of the sections are not relevant, and hence removed.

[ms-henglu]

The failed tests seem unrelated with this change.

[tiesmaster]

The failed tests seem unrelated with this change.

@ms-henglu Indeed, they don't seem related, I trust you on that ;) Is this a private Teamcity instance, as I don't see these in the list of checks?

Is there anything I can do to move this PR forward?

[ms-henglu]

Yes, it's a private team city. The Hashicorp reviewers will review and merge this PR.

[sf-msft]

@tiesmaster What does the delta between 2024-09-01 and 2024-10-01 look like? If review cycles are long, might as well get it to the latest

[tiesmaster]

Sure, I can look into the complexity involved ingesting that delta.

Though, I'm not that keen on doing any more work unless I have a sense of that anything is going to happen from Hashicorp's side. I created this PR over a month ago, and nothing has happened so far. I have pinged people multiple times in the Terraform community Slack, so I, for sure, am out of options.

Unless you know who I can ping for this or someone of Hashicorp steps in, I'm going to leave this PR as it is.

[stephybun]

@tiesmaster apologies for the delay in review here and thanks for running the tests on this PR @ms-henglu. Would you mind resolving the merge conflicts? Once that's done this should be good to go.

[tiesmaster]

@stephybun No worries, thanks for getting to the PR. Looking at the changes, and merge conflicts, it seems like there is a little bit more needed than only resolving the merge conflict. It looks like an additional AKS API has been pulled in (trustedaccess) in the mean time, and I will need to upgrade that API as well (so also vendor the new version of that).

I will do that in 3 to 4 days (max a week).

[stephybun]

@tiesmaster trustedaccess was an emergency upgrade since the preview version it was on was deprecated. You're welcome to take the time to upgrade this as well, but it would also be acceptable for you to leave the version for trustedaccess alone for the time being and it'll get bumped next time all the containerservice APIs get updated.

[tiesmaster]

@stephybun I've rebased my changes, and fixed the merge conflicts. It was easy to also include the trustedaccess (didn't have any breaking changes), so I took to liberty to include that one as well.

I've ran the unit tests locally, without any issues, and I'm running a smoke test acceptance tests (though, that takes a while, ofc), if that comes back with problems, then I'll convert the PR to draft.

@ms-henglu Can you kick off the tests on your end again? Thank you!

[tiesmaster]

@stephybun Might be good to see if we can move this to the next step, in order to prevent any new merge conflicts to popup.

@ms-henglu Did you manage to kick-off a new test run?

[ms-henglu]

[stephybun]

LGTM ⛰️

[tiesmaster]

Awesome, I'm gonna start working on the main PR for issue #27243